From: stuart hayes <stuart.w.hayes@gmail.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Kyle Meyer <kyle.meyer@hpe.com>, Borislav Petkov <bp@alien8.de>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: acpi: Only set boost MSRs on supported CPUs
Date: Mon, 5 Dec 2022 12:07:05 -0600 [thread overview]
Message-ID: <e5e024a2-a530-9f4f-76f4-5f239b3608a3@gmail.com> (raw)
In-Reply-To: <20221205175744.9746-1-stuart.w.hayes@gmail.com>
On 12/5/2022 11:57 AM, Stuart Hayes wrote:
> Stop trying to set boost MSRs on CPUs that don't support boost.
>
> This corrects a bug in the recent patch "Defer setting boost MSRs".
>
> Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
> ---
> drivers/cpufreq/acpi-cpufreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index bb58175a8d40..a7c5e312340e 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
> if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
> pr_warn(FW_WARN "P-state 0 is not max freq\n");
>
> - set_boost(policy, acpi_cpufreq_driver.boost_enabled);
> + if (acpi_cpufreq_driver.set_boost)
> + set_boost(policy, acpi_cpufreq_driver.boost_enabled);
>
> return result;
>
My apologies--adding Boris, I forgot to put him on the "to" list.
next prev parent reply other threads:[~2022-12-05 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 17:57 [PATCH] cpufreq: acpi: Only set boost MSRs on supported CPUs Stuart Hayes
2022-12-05 18:07 ` stuart hayes [this message]
2022-12-06 10:20 ` Borislav Petkov
2022-12-06 11:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5e024a2-a530-9f4f-76f4-5f239b3608a3@gmail.com \
--to=stuart.w.hayes@gmail.com \
--cc=bp@alien8.de \
--cc=kyle.meyer@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox