From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA32AC4332F for ; Mon, 17 Oct 2022 14:14:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230287AbiJQOOo (ORCPT ); Mon, 17 Oct 2022 10:14:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbiJQOOl (ORCPT ); Mon, 17 Oct 2022 10:14:41 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA6011A3F for ; Mon, 17 Oct 2022 07:14:35 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id n12so18639998wrp.10 for ; Mon, 17 Oct 2022 07:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vq5kCnUtoL+6Ezgs4d51zvzN1gUGsMC/kvnhiOvxhZA=; b=tz3RbYuUFruNlDazal9vUSlnltiLDHvOxIl0LPUBuv6NxoHo4Vq9jqpO+al2nQKQI5 jgcl8xIehpkHmpp4r4Q+IWD+dhvC9i80tQ5Wzp5nQou+s9jLpG8rhqY+Uh7I5z9wMxlt QF2zH65EKK1nXRdZNuvu7k7GEGtmX3+rZ5JWHfOoipbWSqjwn6KyzKKMzAZ85ZEuOHMV bpTAOFrf+BiU+6sZmU/F2OjMtWb1YvTZFJTAJeSXADdnC0J3jbbszwQAP0UX8EnC6t2Q DvyGE8C+YTFM/9xHctANb6CMFAo6zi46s9s+OfhIkFxaQNacgLnWj/3UByTYBYsKua1p 9K6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vq5kCnUtoL+6Ezgs4d51zvzN1gUGsMC/kvnhiOvxhZA=; b=whYtwPqTTxLOr46782dHAtC3EKfVjehg76WwjidM/e0smp2EZFSqGYbUqlDgYOE0pm Kax4h3h49/2DOPj/+lNkh6Q8jerUG/aYuwcGp5TjO2ukcLSAh0jUrALBJWCnYF+S938k DlvPeWLQrjS64+1/655M0wIZH37jjKPHXVmNXFevuPIJVq2ueaEqXynJ+fvLdg+S+p9f 9RP5CYrKx3i7r/a2YDbHH6Exv3iaoG4MOk4Rs7Umdlz2XFim/ohER2zFkmOEiOlhD4Te +WIHzRhR4Ix9k5M4iM76y3YfRukQmLItg5WMi21+bAOfUqb4nVgW2KkJIL5nsC8vY2a8 6m4Q== X-Gm-Message-State: ACrzQf206fWPnVjXQpyMu4k7g+s1nyEDmU9LRvAezZrrPqIJIyVKmm1j 4z9Hs7sKxq/TxjOapiReFV+Ljw== X-Google-Smtp-Source: AMsMyM7CM0UpKnoMrB0XCN0oLx3Pp5aNEqNuOcOBP8m2CUuk58Y8mdiVuC8BXiFJDuJcLQxlD0XrEg== X-Received: by 2002:adf:fd4a:0:b0:22d:d3aa:e004 with SMTP id h10-20020adffd4a000000b0022dd3aae004mr6402643wrs.173.1666016073416; Mon, 17 Oct 2022 07:14:33 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:ea6:24ea:3fe7:64b9? ([2a05:6e02:1041:c10:ea6:24ea:3fe7:64b9]) by smtp.googlemail.com with ESMTPSA id x17-20020adff0d1000000b00231ed902a4esm8608659wro.5.2022.10.17.07.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 07:14:33 -0700 (PDT) Message-ID: Date: Mon, 17 Oct 2022 16:14:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp Content-Language: en-US To: Marek Szyprowski , rafael@kernel.org Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Amit Kucheria , Zhang Rui , Alim Akhtar , "open list:SAMSUNG THERMAL DRIVER" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list References: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com> <20221003132943.1383065-1-daniel.lezcano@linaro.org> <1155a694-b821-d41a-da54-8a9656d90e50@samsung.com> From: Daniel Lezcano In-Reply-To: <1155a694-b821-d41a-da54-8a9656d90e50@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 17/10/2022 15:48, Marek Szyprowski wrote: > Hi Daniel, > > On 03.10.2022 15:29, Daniel Lezcano wrote: >> The driver is assuming the get_critical temperature exists as it is >> inherited by the thermal of ops. But this one has been removed in >> favor of the generic one. >> >> Use the generic thermal_zone_get_crit_temp() function instead >> >> Fixes: 13bea86623b ("thermal/of: Remove of_thermal_get_crit_temp(") >> Reported-by: Marek Szyprowski >> Signed-off-by: Daniel Lezcano > > This patch has been dropped from -next, is there are reason for that? No, my mistake. I dropped it accidentally when I rebased the branch. Thanks for pointing it out. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog