From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38AB61534E2 for ; Mon, 22 Apr 2024 15:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713800069; cv=none; b=blFKGf1nu8X5mbCIJxHAnkw/fdohrF19Jo1p33E3QGr8SAQKb8FS3ltMwnGh9aQvHTHR1fyKpEriUn4PEd58egplXih3JSlfJO5kk952snEOBIb5ZJGi/CkFuvoQyHdeqEh6g6oFANHqwoh+TyTynAq2p9FQ1CFdJzlj89B1XU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713800069; c=relaxed/simple; bh=rFLnY69caO6DCxXEt1GspAQ7lGhSrz3Q5rZCzd4arF0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VTZE5pdMvdlUgnYZIrl64kYPic82gHP600Orb5SQ7GL8M1WMAFLNMco1Uk5pTqXeiSaUfxS31GTZt7uCRmOYSg/mAJuoWVKMYB5CLppczcDrM+NEho3iQKZPljRWtxF8LsUMntwBfnLWKduUUIHgKe0PRRhEEGDrDrsA2WEvDis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mYJmCzPc; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mYJmCzPc" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4196c62bb4eso21659995e9.2 for ; Mon, 22 Apr 2024 08:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713800066; x=1714404866; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Lz4BLGLppaJS4RUqiGyn4/E8WuIMdCWJat0A3CWxGLU=; b=mYJmCzPcf6rf5bwAx4Zgc+8pn22SZbgC4TQaH7WsmXqgCmyx4BJAJ72m2dCbvLuoh1 8eOsL0xOxLEzQwHQruKutD0JR8AQHUfvozd/PL0XWqeq+YKlR9FNODyNXNNbYg10XyjI ys52rVnGkVQ7CZezvVzi0Wm5jL0vR0Cdf/hDoTtOdQisKilrwM3Zw2ARMoit2t+HyKnU SMOlwipg/ybpKPO8CApTVJxCX34eVtcKfdbscLNyIGIhQcIM1Xm61sW8NQecygE0MjaV EMuLORbtZK3GVUX4iQXOhYfJtQGk5kPKrFbjLmHlzS0xjFWun5GwCM+2uFpySRazQhrd dagA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713800066; x=1714404866; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lz4BLGLppaJS4RUqiGyn4/E8WuIMdCWJat0A3CWxGLU=; b=QbCGYWFNawUgyafHsWKNC7pu456fz9aPBCvOmT16qTZdAhQ8mtyJOfI7YH9K7qORuJ DSFUg6cjXUfSOYaBnKPp+y5Z41DqjDMJQ4JFfi4NjJpzZ6iFqdIujCkqMp3L6kykTsTu hH50o0cWjep0UuIYkpxhwimM8tSMEw2yFYCqnNq8vz4Kk5tZAVHyfqjcz5/BCF5kBZyn rN9wLswR7lGRZFsjTikVSVT7qwfnU6fiy/7qdFb96Umrvl7wuAxp92XjwZ2REyL2Vyj2 m82KMfVRNNzm2xQitOq6DGp17xtXPGUFGrNlJAOw8GVMumI42zIr3W+ITig2G7fam+bp kIww== X-Forwarded-Encrypted: i=1; AJvYcCWiIvry0lgpp8qIbUu1fZDweoYAZ2ywuoj+8SpNgKRs2R+ufdLnLYhoFZMNIIomiwfh/OeNlEVydxsvz6GRg9JnO0dL+b6vSWA= X-Gm-Message-State: AOJu0YyxU2CxGTXljjiuBtGJWpjPuWm44SS9EG9hk8QePPgZCPpXrE4v hryxKiCXxdUrj6hIvvqCWmH3DI9OUW58MDXTWxYBQhu8cDYa86QE61Jxnt7QEZw= X-Google-Smtp-Source: AGHT+IH5rX73xaS6keYkyu8tgA9v9NkmtE5lmRGsiDlfEoHkzUAXtqPcF25Q3kCt+0u5ccN57FtUfw== X-Received: by 2002:a05:600c:470b:b0:418:e0cf:dbfe with SMTP id v11-20020a05600c470b00b00418e0cfdbfemr7951667wmo.15.1713800066519; Mon, 22 Apr 2024 08:34:26 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id p8-20020a5d48c8000000b0034af40b2efdsm4198955wrs.108.2024.04.22.08.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 08:34:26 -0700 (PDT) Message-ID: Date: Mon, 22 Apr 2024 17:34:25 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/3] thermal/debugfs: Fix and clean up trip point statistics updates Content-Language: en-US To: Lukasz Luba , "Rafael J. Wysocki" Cc: LKML , Linux PM , "Rafael J. Wysocki" References: <4918025.31r3eYUQgx@kreacher> <3a8f1978-c5df-40d6-91ca-276431bb01e1@arm.com> From: Daniel Lezcano In-Reply-To: <3a8f1978-c5df-40d6-91ca-276431bb01e1@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 22/04/2024 13:37, Lukasz Luba wrote: > Hi Rafael, > > On 4/17/24 14:07, Rafael J. Wysocki wrote: >> Hi Everyone, >> >> The first patch in this series addresses the problem of updating trip >> point statistics prematurely for trip points that have just been >> crossed on the way down (please see the patch changelog for details). >> >> The way it does that renders the following cleanup patch inapplicable: >> >> https://lore.kernel.org/linux-pm/2321994.ElGaqSPkdT@kreacher/ >> >> The remaining two patches in the series are cleanups on top of the >> first one. >> >> This series is based on an older patch series posted last week: >> >> https://lore.kernel.org/linux-pm/13515747.uLZWGnKmhe@kreacher/ >> >> but it can be trivially rebased on top of the current linux-next. >> >> Thanks! >> >> >> > > I've checked this patch patch set on top of your bleeding-edge > which has thermal re-work as well. The patch set looks good > and works properly. > > Although, I have found some issue in this debug info files and > I'm not sure if this is expected or not. If not I can address this > and send some small fix for it. > > When I read the cooling device residency statistics, I don't > get updates for the first time the state is used. It can only > be counted when that state was known and finished it's usage. > > IMO it is not the right behavior, isn't it? Do you mean the right behavior is a regression or we should expect at least the residency to be showed even if the mitigation state is not closed ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog