From: Mario Limonciello <mario.limonciello@amd.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Perry Yuan <perry.yuan@amd.com>,
Kalpana Shetty <kalpana.shetty@amd.com>,
Huang Rui <ray.huang@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] cpufreq/amd-pstate: Dynamic EPP fixes
Date: Fri, 8 May 2026 13:04:28 -0500 [thread overview]
Message-ID: <e8214ac1-4c88-44d7-a4e4-038873c6539b@amd.com> (raw)
In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com>
On 5/8/26 00:17, K Prateek Nayak wrote:
> Few rare race conditions were found when testing the Dynamic EPP feature
> on EPYC platforms:
>
> o Toggling dynamic EPP is essentially a driver switch into the same mode
> and can race with an admin-initiated driver switch which can cause the
> system to hang.
>
> o If a profile change / power supply status change races with the driver
> unloading, it can overwrite the Floor Perf restored in the CPPC_REQ
> register that was meant to be left untouched until the next driver
> load.
>
> o When dynamic mode is disabled, the default EPP hint is set based on
> the power supply mode at the time of driver load which can cause the
> battery to drain faster when starting off from AC supply and then
> switching to battery.
>
> When fixing and testing the above, a couple of incorrect error codes
> were noted which is also fixed in the series along with the unit test.
>
> Series is based on mainline at v7.1-rc2 release tag. Thanks to Mario for
> initial review. Feedback is greatly appreciated.
> ---
> K Prateek Nayak (6):
> cpufreq/amd-pstate: Grab "amd_pstate_driver_lock" when toggling
> dynamic_epp
> cpufreq/amd-pstate: Return -ENOMEM on failure to allocate profile_name
> cpufreq/amd-pstate: Allow writes to dynamic_epp when state isn't
> modified
> cpufreq/amd-pstate: Reorder notifier unregistration and floor perf
> reset
> cpufreq/amd-pstate: Use "epp_default_dc" as default when dynamic_epp
> is disabled
> cpufreq/amd-pstate-ut: Drop policy reference before driver switch
>
> drivers/cpufreq/amd-pstate-ut.c | 36 ++++++++++++++++++++++++++-------
> drivers/cpufreq/amd-pstate.c | 23 ++++++++++++++++-----
> 2 files changed, 47 insertions(+), 12 deletions(-)
>
>
> base-commit: 7fd2df204f342fc17d1a0bfcd474b24232fb0f32
Much appreciated. I've staged these in amd-pstate-fixes and will send
out the PR next week after more testing.
prev parent reply other threads:[~2026-05-08 18:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 5:17 [PATCH 0/6] cpufreq/amd-pstate: Dynamic EPP fixes K Prateek Nayak
2026-05-08 5:17 ` [PATCH 1/6] cpufreq/amd-pstate: Grab "amd_pstate_driver_lock" when toggling dynamic_epp K Prateek Nayak
2026-05-08 5:17 ` [PATCH 2/6] cpufreq/amd-pstate: Return -ENOMEM on failure to allocate profile_name K Prateek Nayak
2026-05-08 5:17 ` [PATCH 3/6] cpufreq/amd-pstate: Allow writes to dynamic_epp when state isn't modified K Prateek Nayak
2026-05-08 5:17 ` [PATCH 4/6] cpufreq/amd-pstate: Reorder notifier unregistration and floor perf reset K Prateek Nayak
2026-05-08 5:17 ` [PATCH 5/6] cpufreq/amd-pstate: Use "epp_default_dc" as default when dynamic_epp is disabled K Prateek Nayak
2026-05-08 5:17 ` [PATCH 6/6] cpufreq/amd-pstate-ut: Drop policy reference before driver switch K Prateek Nayak
2026-05-08 18:04 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8214ac1-4c88-44d7-a4e4-038873c6539b@amd.com \
--to=mario.limonciello@amd.com \
--cc=kalpana.shetty@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox