From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@sisk.pl
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 11/16] cpufreq: ppc: use cpufreq_generic_get() routine
Date: Fri, 23 Aug 2013 21:20:46 +0530 [thread overview]
Message-ID: <e99f1b893f4ff3987b441e5f0116c8106bfd9deb.1377272740.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1377272740.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1377272740.git.viresh.kumar@linaro.org>
We have common infrastructure available with us for getting a CPUs clk rate.
Lets use it for this driver.
We don't need a variable to hold clock anymore in struct cpu_data.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/ppc-corenet-cpufreq.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c b/drivers/cpufreq/ppc-corenet-cpufreq.c
index 3f7be46..051000f 100644
--- a/drivers/cpufreq/ppc-corenet-cpufreq.c
+++ b/drivers/cpufreq/ppc-corenet-cpufreq.c
@@ -24,12 +24,10 @@
/**
* struct cpu_data - per CPU data struct
- * @clk: the clk of CPU
* @parent: the parent node of cpu clock
* @table: frequency table
*/
struct cpu_data {
- struct clk *clk;
struct device_node *parent;
struct cpufreq_frequency_table *table;
};
@@ -81,13 +79,6 @@ static inline const struct cpumask *cpu_core_mask(int cpu)
}
#endif
-static unsigned int corenet_cpufreq_get_speed(unsigned int cpu)
-{
- struct cpu_data *data = per_cpu(cpu_data, cpu);
-
- return clk_get_rate(data->clk) / 1000;
-}
-
/* reduce the duplicated frequencies in frequency table */
static void freq_table_redup(struct cpufreq_frequency_table *freq_table,
int count)
@@ -158,8 +149,8 @@ static int corenet_cpufreq_cpu_init(struct cpufreq_policy *policy)
goto err_np;
}
- data->clk = of_clk_get(np, 0);
- if (IS_ERR(data->clk)) {
+ policy->clk = of_clk_get(np, 0);
+ if (IS_ERR(policy->clk)) {
pr_err("%s: no clock information\n", __func__);
goto err_nomem2;
}
@@ -255,7 +246,7 @@ static int corenet_cpufreq_target(struct cpufreq_policy *policy,
struct cpu_data *data = per_cpu(cpu_data, policy->cpu);
parent = of_clk_get(data->parent, data->table[index].driver_data);
- return clk_set_parent(data->clk, parent);
+ return clk_set_parent(policy->clk, parent);
}
static struct cpufreq_driver ppc_corenet_cpufreq_driver = {
@@ -265,7 +256,7 @@ static struct cpufreq_driver ppc_corenet_cpufreq_driver = {
.exit = __exit_p(corenet_cpufreq_cpu_exit),
.verify = cpufreq_generic_frequency_table_verify,
.target_index = corenet_cpufreq_target,
- .get = corenet_cpufreq_get_speed,
+ .get = cpufreq_generic_get,
.attr = cpufreq_generic_attr,
};
--
1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2013-08-23 15:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 15:50 [PATCH 00/16] cpufreq: create & use cpufreq_generic_get() routine Viresh Kumar
2013-08-23 15:50 ` [PATCH 01/16] cpufreq: create " Viresh Kumar
2013-08-23 15:50 ` [PATCH 02/16] cpufreq: arm_big_little: use " Viresh Kumar
2013-08-23 15:50 ` [PATCH 03/16] cpufreq: at32ap: " Viresh Kumar
2013-08-26 7:12 ` Hans-Christian Egtvedt
2013-08-23 15:50 ` [PATCH 04/16] cpufreq: cpu0: " Viresh Kumar
2013-08-29 13:07 ` Shawn Guo
2013-08-23 15:50 ` [PATCH 05/16] cpufreq: davinci: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 06/16] cpufreq: dbx500: " Viresh Kumar
2013-08-28 12:14 ` Linus Walleij
2013-08-23 15:50 ` [PATCH 07/16] cpufreq: exynos: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 08/16] cpufreq: imx6q: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 09/16] cpufreq: loongson2: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 10/16] cpufreq: omap: " Viresh Kumar
2013-08-23 15:50 ` Viresh Kumar [this message]
2013-08-23 15:50 ` [PATCH 12/16] cpufreq: s3c: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 13/16] cpufreq: s5pv210: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 14/16] cpufreq: spear: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 15/16] cpufreq: tegra: " Viresh Kumar
2013-08-23 15:50 ` [PATCH 16/16] cpufreq: unicore2: " Viresh Kumar
2013-08-23 19:40 ` [PATCH 00/16] cpufreq: create & " Rafael J. Wysocki
2013-08-24 4:20 ` Viresh Kumar
2013-08-24 14:50 ` Rafael J. Wysocki
2013-08-26 4:30 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e99f1b893f4ff3987b441e5f0116c8106bfd9deb.1377272740.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).