From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1314DCD37B4 for ; Tue, 19 Sep 2023 03:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231494AbjISDzP (ORCPT ); Mon, 18 Sep 2023 23:55:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231491AbjISDzD (ORCPT ); Mon, 18 Sep 2023 23:55:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEFB7121 for ; Mon, 18 Sep 2023 20:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695095648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=opGMZb4zVfpw4j3bwF+zyk+VH4LC+VDK5rPEHS4VpxU=; b=GK/Dw6pdhLZD/5K9KU3TSZGSiOyvEw3nphSmp/W6Olk6VVQGWolDqA5DysDCin4Qwl8bwk NmuCOPmr7A0EilzsNcmD7NCCnEzxIbkGP8mSzcuJBNFk000zkMjIAyiU5MvsV1ePSxqH/E Q/urbzYdWGUbIyZHANqE4wepZywKAAs= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-osQT33N2M9OWoWHQf6bo9g-1; Mon, 18 Sep 2023 23:54:05 -0400 X-MC-Unique: osQT33N2M9OWoWHQf6bo9g-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3adbcfd059aso4518121b6e.0 for ; Mon, 18 Sep 2023 20:54:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695095644; x=1695700444; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opGMZb4zVfpw4j3bwF+zyk+VH4LC+VDK5rPEHS4VpxU=; b=JDbJ8QFQo+uhk0uT2t3Ey/IwM90rUUXNblVKH8XC6cy8izESopi4EcI+soUTxlymE+ Gv33tBJTczj25bG0hO9atat0+ZvAePTSeEURb6DQa/2g+an5liVfBm83wCokVMT8pGfG 8NRRr86LGfoLi9PWdjQwKT+ilcsa2exa4f86YVP3Qtf8+zT2Q1P9dSVrgy9WKrX9vVKv qOsNwxK3UVeRIOFVPeXOOr8/JENuDS/LIz33qfMvt9m+AfO7UKFQ2xHzYh/UcUN+mQSI natDUxxUbkNKk+Urv61DhLvbopkzsl9J5ZyRJluOFQmpEYxujUANVBm156BxhiyADr1m nG7A== X-Gm-Message-State: AOJu0YyAHrc5Z+p6Ei/PKAbkIhclusMmy8oRFOa+E4HIZdpaxRSoBIre Z2l8AaqfK1oK+avp8hDGo1CnmHRcWLB6zQGL4F89tPYw1mhhGrXGzFlSor+Cau+V3dL3cKZwfie Tmp05lKcteXoozlAecI4= X-Received: by 2002:a54:4504:0:b0:3a3:76c6:a46f with SMTP id l4-20020a544504000000b003a376c6a46fmr12922329oil.38.1695095644171; Mon, 18 Sep 2023 20:54:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGYlj7TJDnGHj/RWXEc2C+lTOzyiwCCuIn5mHVU8DsjC6vooAlJ9Xs3Gr3phqs2j6qI73HUw== X-Received: by 2002:a54:4504:0:b0:3a3:76c6:a46f with SMTP id l4-20020a544504000000b003a376c6a46fmr12922314oil.38.1695095643929; Mon, 18 Sep 2023 20:54:03 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id s5-20020a17090a948500b0026b3f76a063sm7639370pjo.44.2023.09.18.20.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 20:54:03 -0700 (PDT) Message-ID: Date: Tue, 19 Sep 2023 13:53:56 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH v2 30/35] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs Content-Language: en-US To: "Russell King (Oracle)" , James Morse Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com References: <20230913163823.7880-1-james.morse@arm.com> <20230913163823.7880-31-james.morse@arm.com> From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 9/14/23 18:10, Russell King (Oracle) wrote: > On Wed, Sep 13, 2023 at 04:38:18PM +0000, James Morse wrote: >> static inline bool acpi_gicc_is_usable(struct acpi_madt_generic_interrupt *gicc) >> { >> - return (gicc->flags & ACPI_MADT_ENABLED); >> + return ((gicc->flags & ACPI_MADT_ENABLED || >> + gicc->flags & ACPI_MADT_GICC_CPU_CAPABLE)); > > ... and this starts getting silly with the number of parens. > > return gicc->flags & ACPI_MADT_ENABLED || > gicc->flags & ACPI_MADT_GICC_CPU_CAPABLE; > > is entirely sufficient. Also: > > return gicc->flags & (ACPI_MADT_ENABLED | ACPI_MADT_GICC_CPU_CAPABLE); > > also works. > vote for the second one, which is: gicc->flags & (ACPI_MADT_ENABLED | ACPI_MADT_GICC_CPU_CAPABLE) Thanks, Gavin