From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.auroraos.dev (unknown [95.181.193.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD01253CA70 for ; Wed, 23 Sep 2026 20:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.181.193.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790196295; cv=none; b=EQFcd3NHlHUt2gdzvF3yYtfRpdmPxmp45A/sSbCbFao+cAL/SLkz31OVgLF2GEfBXqEzJtTDsn+EYqis77acZGFmAih966IdJ/sir/XdnbHu6Ef0D/q5jtGpPvxwS02IC+jgxTED2t4LqC3HXUxHFVXOKl8sffph+cICKJsTGPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790196295; c=relaxed/simple; bh=4cMOqIMZKwKIxMjsKtP2EJNpWImYEYamewt1djpz8uQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=KZbPPV/iq9oMb6FYZe+zl2tht3AqHTyluWjw26Cj0nm/bmxPEn3gLTW7//zfzHpqXH73v1t8LTAIaew31+wgLXpY4fPFtU93nrzy4YfzXuBsd31lEKvyFbMdELE3ZeF6B0guAAEmau/baS6epI1gYX1ccBMByAXvhhJaGHNQYuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=auroraos.dev; spf=pass smtp.mailfrom=auroraos.dev; arc=none smtp.client-ip=95.181.193.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=auroraos.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=auroraos.dev Received: from [192.168.2.104] (91.78.46.39) by exch16.corp.auroraos.dev (10.189.209.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 23 Sep 2026 23:44:46 +0300 Message-ID: Date: Wed, 23 Sep 2026 23:44:46 +0300 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pmdomain: rockchip: fix domain check in rockchip_pm_add_one_domain() To: Ulf Hansson CC: Ulf Hansson , Heiko Stuebner , , , Caesar Wang , Kevin Hilman , References: <20260920175928.42566-1-s.shtylyov@auroraos.dev> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: exch16.corp.auroraos.dev (10.189.209.38) To exch16.corp.auroraos.dev (10.189.209.38) On 9/23/26 3:14 PM, Ulf Hansson wrote: [...] >> In rockchip_pm_add_one_domain(), there's the check (most probably for >> the case where the "reg" prop has an unexpected value?) which doesn't >> make much sense as the variable pd_info will be NULL iff pmu->info-> >> domain_info is NULL and the variable id is 0. What does make sense >> there is checking pd_info->pwr_mask and pd_info->req_mask which (as >> seems to follow from the code) can't both be 0 for a valid domain... >> >> Found by Linux Verification Center (linuxtesting.org) with the Svace >> static analysis tool. >> >> Fixes: 7c696693a4f5 ("soc: rockchip: power-domain: Add power domain driver") >> Signed-off-by: Sergey Shtylyov > > Applied for next, but without the fixes tag, thanks! > > Note, that I am dropping the fixes tag because if there was a real > problem, we would require yet another fix on top to get the > corresponding domain declaration to be correct. Yet, the patch is > useful as is! I was thinking of doing a more elaborate description but if you considered it good enough, OK... :-) > Kind regards > Uffe [...] MBR, Sergey