From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Date: Fri, 30 Jun 2017 19:42:06 +0200 Message-ID: References: <20170629121009.30234-1-benjamin.tissoires@redhat.com> <20170630155706.GL26073@mail.corp.redhat.com> <7d8201bf-b05e-6235-7eb0-54b1a393f99f@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Benjamin Tissoires , Bastien Nocera , Stephen Just , Sebastian Reichel , "Rafael J . Wysocki" , Len Brown , Robert Moore , Lv Zheng , Mika Westerberg , "linux-acpi@vger.kernel.org" , devel@acpica.org, "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-pm@vger.kernel.org Hi, On 30-06-17 19:40, Andy Shevchenko wrote: > On Fri, Jun 30, 2017 at 8:37 PM, Hans de Goede wrote: >> On 30-06-17 18:37, Andy Shevchenko wrote: >>> On Fri, Jun 30, 2017 at 6:57 PM, Benjamin Tissoires > >> ACPI i2c drivers still need an empty i2c_device_id table I've >> fixing this on my TODO but it has been buried in other stuff. >> >> Benjamin if (not saying you should, but if) you want to take a look at >> this, fixing the need for the empty table for ACPI devices should be >> easy. The problem is these lines in drivers/i2c/i2c-core.c: >> i2c_device_probe(): >> >> /* >> * An I2C ID table is not mandatory, if and only if, a suitable >> Device >> * Tree match table entry is supplied for the probing device. >> */ >> if (!driver->id_table && >> !i2c_of_match_device(dev->driver->of_match_table, client)) >> return -ENODEV; >> >> Which needs to be extended to also check for an ACPI match AFAIK >> you can NOT just replace this with i2c_device_match because that would >> break manually binding a driver through sysfs. > > I have a stashed change for that, just have no time to look closer. Care to share that? Between me and Benjamin one of us can hopefully find the time to test / finish it (should be trivial really). Regards, Hans