Re: [PATCH 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL

Daniel Lezcano
2019-03-28T17:27:49Z

On 28/03/2019 11:22, Quentin Perret wrote:
> On Thursday 28 Mar 2019 at 10:13:50 (+0000), Quentin Perret wrote:
>> The recently introduced Energy Model (EM) framework manages power cost
>> tables for the CPUs of the system. Its only user right now is the
>> scheduler, in the context of Energy Aware Scheduling (EAS).
>>
>> However, the EM framework also offers a generic infrastructure that
>> could replace subsystem-specific implementations of the same concepts,
>> as this is the case in the thermal framework.
>>
>> So, in order to prepare the migration of the thermal subsystem to use
>> the EM framework, enable it in the default arm64 defconfig, which is the
>> most commonly used architecture for IPA. This will also compile-in all
>> of the EAS code, although it won't be enabled by default -- EAS requires
>> to use the 'schedutil' CPUFreq governor while arm64 defaults to
>> 'performance'.
>>
>> Signed-off-by: Quentin Perret <quentin.perret@arm.com>
>> ---
>> arch/arm64/configs/defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 2d9c39033c1a..3c09bdaaefd3 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -97,6 +97,7 @@ CONFIG_XEN=y
>> CONFIG_COMPAT=y
>> CONFIG_HIBERNATION=y
>> CONFIG_WQ_POWER_EFFICIENT_DEFAULT=y
>> +CONFIG_ENERGY_MODEL=n
>
> Hmm, sorry I turned this to '=n' for testing and forgot to update the
> patch. This obviously should be '=y' ...

I did a test without the ENERGY_MODEL config option set, dhrystone and
the power_allocator policy on the hikey. The board did not mitigate well
and ended up rebooting. May be the cpu cooling Kconfig option should add
a SELECT or a DEPENDS on ENERGY_MODEL ?

>> CONFIG_ARM_CPUIDLE=y
>> CONFIG_CPU_FREQ=y
>> CONFIG_CPU_FREQ_STAT=y
>> --
>> 2.21.0
>>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |