Re: [PATCH v2 2/2] power: supply: bq25890: Add new linux,iinlim-percentage property

[Hans de Goede <hdegoede@redhat.com>]

Hi Marek,

On 1/25/23 14:02, Marek Vasut wrote:
> On 1/25/23 11:58, Hans de Goede wrote:
> 
> [...]
> 
>> @@ -1390,6 +1404,17 @@ static int bq25890_fw_probe(struct bq25890_device *bq)
>>       device_property_read_u32(bq->dev, "linux,pump-express-vbus-max",
>>                    &bq->pump_express_vbus_max);
>>   +    ret = device_property_read_u32(bq->dev, "linux,iinlim-percentage", &val);
>> +    if (ret == 0) {
>> +        if (val > 100) {
>> +            dev_err(bq->dev, "Error linux,iinlim-percentage %u > 100\n", val);
>> +            return -EINVAL;
>> +        }
>> +        bq->iinlim_percentage = val;
>> +    } else {
>> +        bq->iinlim_percentage = 100;
>> +    }
> 
> Should we really return -EINVAL if > 100 % or shall we clamp the value instead ?

Either one will work, returning -EINVAL frpm probe() for invalid property
values is something other drivers do to AFAIK.

I don't really have a preference either way.

Regards,

Hans