From: Viresh Kumar <viresh.kumar@linaro.org>
To: Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] thermal: cpu_cooling: Replace kmalloc with kmalloc_array
Date: Tue, 23 May 2017 12:33:06 +0530 [thread overview]
Message-ID: <eff10695c92ff2d2e9733987d1b06adf559c07b0.1495522926.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <1495521460.2303.4.camel@intel.com>
Checkpatch reports following:
WARNING: Prefer kmalloc_array over kmalloc with multiply
+ cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * i,
Fix that.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/thermal/cpu_cooling.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 1305020790b2..908a8014cf76 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -724,8 +724,9 @@ __cpufreq_cooling_register(struct device_node *np,
/* max_level is an index, not a counter */
cpufreq_cdev->max_level = i - 1;
- cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * i,
- GFP_KERNEL);
+ cpufreq_cdev->freq_table = kmalloc_array(i,
+ sizeof(*cpufreq_cdev->freq_table),
+ GFP_KERNEL);
if (!cpufreq_cdev->freq_table) {
cdev = ERR_PTR(-ENOMEM);
goto free_idle_time;
--
2.13.0.70.g6367777092d9
next prev parent reply other threads:[~2017-05-23 7:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 10:27 [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 02/17] thermal: cpu_cooling: rearrange globals Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev Viresh Kumar
2017-05-23 6:37 ` Zhang Rui
2017-05-23 7:03 ` Viresh Kumar [this message]
2017-05-24 2:27 ` [PATCH] thermal: cpu_cooling: Replace kmalloc with kmalloc_array Eduardo Valentin
2017-05-24 3:51 ` Viresh Kumar
2017-05-23 7:04 ` [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 04/17] thermal: cpu_cooling: replace cool_dev with cdev Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 05/17] thermal: cpu_cooling: remove cpufreq_cooling_get_level() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 06/17] thermal: cpu_cooling: get rid of a variable in cpufreq_set_cur_state() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 07/17] thermal: cpu_cooling: use cpufreq_policy to register cooling device Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 08/17] cpufreq: create cpufreq_table_count_valid_entries() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 09/17] thermal: cpu_cooling: store cpufreq policy Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 10/17] thermal: cpu_cooling: OPPs are registered for all CPUs Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 11/17] thermal: cpu_cooling: get rid of 'allowed_cpus' Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 12/17] thermal: cpu_cooling: merge frequency and power tables Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 13/17] thermal: cpu_cooling: create structure for idle time stats Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 14/17] thermal: cpu_cooling: get_level() can't fail Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 15/17] thermal: cpu_cooling: don't store cpu_dev in cpufreq_cdev Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 16/17] thermal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power() Viresh Kumar
2017-04-25 10:27 ` [PATCH V4 17/17] thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device Viresh Kumar
2017-04-26 10:41 ` [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Lukasz Luba
2017-04-26 10:47 ` Viresh Kumar
2017-04-27 16:26 ` Eduardo Valentin
2017-04-28 4:24 ` Viresh Kumar
2017-05-26 4:57 ` Viresh Kumar
2017-05-28 0:29 ` Eduardo Valentin
2017-05-24 2:41 ` Eduardo Valentin
2017-05-24 3:53 ` Viresh Kumar
2017-05-24 4:03 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff10695c92ff2d2e9733987d1b06adf559c07b0.1495522926.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).