From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [Bug] ARM: mxs: STI: console can't wake up from freeze Date: Sun, 6 Nov 2016 15:55:06 +0100 Message-ID: References: <20161023133134.GI1041@n2100.armlinux.org.uk> <1709157673.85170.1cb53b4d-2805-48ea-aef1-dd282306d108.open-xchange@email.1und1.de> <20161031161700.GH1041@n2100.armlinux.org.uk> <847975190.29034.38a9c7fa-bdf8-4732-ac8b-cf15c21e3ce8.open-xchange@email.1und1.de> <20161101092304.GM1041@n2100.armlinux.org.uk> <322177156.158733.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> <1478345972.2206.15.camel@intel.com> <122295766.159553.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> <20161105130034.GG15759@mai> <1113068116.152452.34665947-6f6b-41d6-92af-eabcbcb794ea.open-xchange@email.1und1.de> <20161105180542.GE1041@n2100.armlinux.org.uk> <381813296.167766.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:38355 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbcKFOzL (ORCPT ); Sun, 6 Nov 2016 09:55:11 -0500 Received: by mail-wm0-f42.google.com with SMTP id f82so74163367wmf.1 for ; Sun, 06 Nov 2016 06:55:10 -0800 (PST) In-Reply-To: <381813296.167766.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Stefan Wahren , Russell King - ARM Linux Cc: "Rafael J. Wysocki" , Sascha Hauer , Zhang Rui , Shawn Guo , joerg.krause@embedded.rocks, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam On 06/11/2016 11:20, Stefan Wahren wrote: > Hi, > >> Russell King - ARM Linux hat am 5. November 2016 um >> 19:05 geschrieben: >> >> >> On Sat, Nov 05, 2016 at 04:28:37PM +0100, Stefan Wahren wrote: >>> As i wrote in my email before, i added a pr_info() into freeze_wake. >>> But i never see the output of this message. So i assume freeze_wake >>> is never called. Again, how could this happen? >> >> Hmm, so the bit that you're getting stuck on is: >> >> wait_event(suspend_freeze_wait_head, >> suspend_freeze_state == FREEZE_STATE_WAKE); >> > > thanks for all the feedback. The real cause for this issue is in the irqchip > driver. I fixed it with this patch: Mind to give some details ? > diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c > index 1730470..05fa9f7 100644 > --- a/drivers/irqchip/irq-mxs.c > +++ b/drivers/irqchip/irq-mxs.c > @@ -131,12 +131,16 @@ static void asm9260_unmask_irq(struct irq_data *d) > .irq_ack = icoll_ack_irq, > .irq_mask = icoll_mask_irq, > .irq_unmask = icoll_unmask_irq, > + .flags = IRQCHIP_MASK_ON_SUSPEND | > + IRQCHIP_SKIP_SET_WAKE, > }; > > static struct irq_chip asm9260_icoll_chip = { > .irq_ack = icoll_ack_irq, > .irq_mask = asm9260_mask_irq, > .irq_unmask = asm9260_unmask_irq, > + .flags = IRQCHIP_MASK_ON_SUSPEND | > + IRQCHIP_SKIP_SET_WAKE, > }; > > asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs) > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog