Re: [PATCH 4/6] dt-bindings: thermal: versal: Add description for Versal Thermal

Conor Dooley
2025-09-05T18:30:27Z

[-- Attachment #1: Type: text/plain, Size: 2674 bytes --]

On Fri, Sep 05, 2025 at 10:41:47AM +0200, Michal Simek wrote:
> From: Salih Erim <salih.erim@amd.com>
>
> Add description of Versal Thermal which describes IO channels to
> be binded to thermal. Constant channel of "sysmon-temp-channel" used as
> mapped iio channel.
>
> One temperature zone is used for the AI Engine temperature monitoring.
>
> Signed-off-by: Salih Erim <salih.erim@amd.com>
> Co-developed-by: Anish Kadamathikuttiyil Karthikeyan Pillai <anish.kadamathikuttiyil-karthikeyan-pillai@amd.com>
> Signed-off-by: Anish Kadamathikuttiyil Karthikeyan Pillai <anish.kadamathikuttiyil-karthikeyan-pillai@amd.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> .../bindings/thermal/xlnx,versal-thermal.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/xlnx,versal-thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/xlnx,versal-thermal.yaml b/Documentation/devicetree/bindings/thermal/xlnx,versal-thermal.yaml
> new file mode 100644
> index 000000000000..c374d7ae2d2a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/xlnx,versal-thermal.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/xlnx,versal-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xilinx Versal Thermal
> +
> +maintainers:
> + - Salih Erim <salih.erim@amd.com>
> +
> +description:
> + Versal Thermal uses Versal Sysmon hardware for temperature reading.
> + It works as sensor interface to be defined in thermal zones.
> +
> +properties:
> + compatible:
> + const: xlnx,versal-thermal

BTW Michal, what's the story with using amd v xlnx for bindings?
Planning to use amd for new devices and xlnx for stuff sold before the
purchase or something like that?

> +
> + '#thermal-sensor-cells':
> + const: 1
> +
> + io-channels:
> + maxItems: 1
> +
> + io-channel-names:
> + const: sysmon-temp-channel
> +
> +required:
> + - compatible
> + - '#thermal-sensor-cells'
> + - io-channels
> + - io-channel-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + versal-thermal-sensor {

Drop the versal from the node name here please.
With that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> + compatible = "xlnx,versal-thermal";
> + #thermal-sensor-cells = <1>;
> + io-channels = <&sysmon0>;
> + io-channel-names = "sysmon-temp-channel";
> + };
> +...
> --
> 2.43.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]