From: Shuah Khan <skhan@linuxfoundation.org>
To: "Kumar, Kaushlendra" <kaushlendra.kumar@intel.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"jwyatt@redhat.com" <jwyatt@redhat.com>,
"jkacur@redhat.com" <jkacur@redhat.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] cpupower: remove extern declarations in cmd_set()
Date: Wed, 1 Apr 2026 12:53:16 -0600 [thread overview]
Message-ID: <f0bcad85-81e9-451d-8267-729b60531590@linuxfoundation.org> (raw)
In-Reply-To: <LV3PR11MB87682C0658A16EC72B47FB72F550A@LV3PR11MB8768.namprd11.prod.outlook.com>
On 3/31/26 20:49, Kumar, Kaushlendra wrote:
> On 4/1/26 XX:XX, Shuah Khan wrote:
>> Okay - are there errors from compilers or static checkers? How did you find the problem?
>
> No errors from compilers or static checkers. We found this while doing
> local code modifications to the file. During the review of the changes,
> we noticed the redundant extern declarations and cleaned them up as part
> of good housekeeping.
There are a few other places in cpupower that can be fixed. Send
me a patch that removes just the extern declarations without the
parse_int_range() stuff
extern char *optarg;
extern int optind, opterr, optopt;
thanks,
-- Shuah
next prev parent reply other threads:[~2026-04-01 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 4:59 [PATCH] cpupower: remove extern declarations in cmd_set() Kaushlendra Kumar
2026-03-31 23:53 ` Shuah Khan
2026-04-01 2:49 ` Kumar, Kaushlendra
2026-04-01 18:53 ` Shuah Khan [this message]
2026-04-02 15:45 ` Kumar, Kaushlendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0bcad85-81e9-451d-8267-729b60531590@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=kaushlendra.kumar@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox