[PATCH] cpupower: remove extern declarations in cmd_set()

[PATCH] cpupower: remove extern declarations in cmd_set()

[Kaushlendra Kumar]

extern char *optarg and extern int optind, opterr, optopt are
already declared by <getopt.h>, which is included at the top of
the file. Repeating extern declarations inside a function body
is misleading and unnecessary.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
 tools/power/cpupower/utils/cpupower-set.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
index dcbdff5c9ae5..64d2d4b070b4 100644
--- a/tools/power/cpupower/utils/cpupower-set.c
+++ b/tools/power/cpupower/utils/cpupower-set.c
@@ -51,8 +51,6 @@ static int parse_int_range(const char *arg, int min, int max, int *out)
 
 int cmd_set(int argc, char **argv)
 {
-	extern char *optarg;
-	extern int optind, opterr, optopt;
 	unsigned int cpu;
 	struct utsname uts;
 
-- 
2.34.1

Re: [PATCH] cpupower: remove extern declarations in cmd_set()

[Shuah Khan]

On 3/30/26 22:59, Kaushlendra Kumar wrote:
> extern char *optarg and extern int optind, opterr, optopt are
> already declared by <getopt.h>, which is included at the top of
> the file. Repeating extern declarations inside a function body
> is misleading and unnecessary.

Okay - are there errors from compilers or static checkers? How
did you find the problem?
> 
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
>   tools/power/cpupower/utils/cpupower-set.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
> index dcbdff5c9ae5..64d2d4b070b4 100644
> --- a/tools/power/cpupower/utils/cpupower-set.c
> +++ b/tools/power/cpupower/utils/cpupower-set.c
> @@ -51,8 +51,6 @@ static int parse_int_range(const char *arg, int min, int max, int *out)
>   
>   int cmd_set(int argc, char **argv)
>   {
> -	extern char *optarg;
> -	extern int optind, opterr, optopt;
>   	unsigned int cpu;
>   	struct utsname uts;
>   

thanks,
-- Shuah

RE: [PATCH] cpupower: remove extern declarations in cmd_set()

[Kumar, Kaushlendra]

On 4/1/26 XX:XX, Shuah Khan wrote:
> Okay - are there errors from compilers or static checkers? How did you find the problem?

No errors from compilers or static checkers. We found this while doing
local code modifications to the file. During the review of the changes,
we noticed the redundant extern declarations and cleaned them up as part
of good housekeeping.

Thanks,
Kaushlendra Kumar

Re: [PATCH] cpupower: remove extern declarations in cmd_set()

[Shuah Khan]

On 3/31/26 20:49, Kumar, Kaushlendra wrote:
> On 4/1/26 XX:XX, Shuah Khan wrote:
>> Okay - are there errors from compilers or static checkers? How did you find the problem?
> 
> No errors from compilers or static checkers. We found this while doing
> local code modifications to the file. During the review of the changes,
> we noticed the redundant extern declarations and cleaned them up as part
> of good housekeeping.

There are a few other places in cpupower that can be fixed. Send
me a patch that removes just the extern declarations without the
parse_int_range() stuff

extern char *optarg;
extern int optind, opterr, optopt;

thanks,
-- Shuah

RE: [PATCH] cpupower: remove extern declarations in cmd_set()

[Kumar, Kaushlendra]

> There are a few other places in cpupower that can be fixed. Send me a
> patch that removes just the extern declarations without the
> parse_int_range() stuff
>
> extern char *optarg;
> extern int optind, opterr, optopt;

Sure, will do.

Thanks,
Kaushlendra