From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Maíra Canal" <mcanal@igalia.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Nick Alcock" <nick.alcock@oracle.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Melissa Wen" <mwen@igalia.com>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel-dev@igalia.com
Subject: Re: [PATCH v2] pmdomain: bcm: bcm2835-power: check if the ASB register is equal to enable
Date: Mon, 23 Oct 2023 17:29:07 -0700 [thread overview]
Message-ID: <f1b7a6a5-141c-4f68-83de-b00fc8bb7794@broadcom.com> (raw)
In-Reply-To: <20231023233545.529519-2-mcanal@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On 10/23/2023 4:35 PM, Maíra Canal wrote:
> The commit c494a447c14e ("soc: bcm: bcm2835-power: Refactor ASB control")
> refactored the ASB control by using a general function to handle both
> the enable and disable. But this patch introduced a subtle regression:
> we need to check if !!(readl(base + reg) & ASB_ACK) == enable, not just
> check if (readl(base + reg) & ASB_ACK) == true.
>
> Currently, this is causing an invalid register state in V3D when
> unloading and loading the driver, because `bcm2835_asb_disable()` will
> return -ETIMEDOUT and `bcm2835_asb_power_off()` will fail to disable the
> ASB slave for V3D.
>
> Fixes: c494a447c14e ("soc: bcm: bcm2835-power: Refactor ASB control")
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Good catch!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-10-24 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 23:35 [PATCH v2] pmdomain: bcm: bcm2835-power: check if the ASB register is equal to enable Maíra Canal
2023-10-24 0:29 ` Florian Fainelli [this message]
2023-10-24 5:54 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1b7a6a5-141c-4f68-83de-b00fc8bb7794@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kernel-dev@igalia.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mcanal@igalia.com \
--cc=mwen@igalia.com \
--cc=nick.alcock@oracle.com \
--cc=pbrobinson@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox