From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path
Date: Mon, 19 Aug 2024 12:12:18 +0200 [thread overview]
Message-ID: <f3d2c104-360a-4da0-8d77-59af89ebda2b@linaro.org> (raw)
In-Reply-To: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org>
On 14/08/2024 21:58, Krzysztof Kozlowski wrote:
> Terminating for_each_child_of_node() loop requires dropping OF node
> reference, so bailing out after thermal_of_populate_trip() error misses
> this. Solve the OF node reference leak with scoped
> for_each_child_of_node_scoped().
>
> Fixes: d0c75fa2c17f ("thermal/of: Initialize trip points separately")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Applied, thanks for the fixes
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2024-08-19 10:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 19:58 [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path Krzysztof Kozlowski
2024-08-14 19:58 ` [PATCH 2/3] thermal: of: Fix OF node leak in thermal_of_zone_register() Krzysztof Kozlowski
2024-08-15 4:51 ` Chen-Yu Tsai
2024-08-22 16:10 ` Daniel Lezcano
2024-08-14 19:58 ` [PATCH 3/3] thermal: of: Fix OF node leak in of_thermal_zone_find() error paths Krzysztof Kozlowski
2024-08-15 4:54 ` Chen-Yu Tsai
2024-08-22 16:11 ` Daniel Lezcano
2024-08-22 19:05 ` Rafael J. Wysocki
2024-08-15 4:48 ` [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path Chen-Yu Tsai
2024-08-15 6:48 ` Markus Elfring
2024-08-19 10:12 ` Daniel Lezcano [this message]
2024-08-19 13:20 ` Rafael J. Wysocki
2024-08-19 13:22 ` Daniel Lezcano
2024-08-19 13:31 ` Rafael J. Wysocki
2024-08-22 15:54 ` Rafael J. Wysocki
2024-08-22 16:09 ` Daniel Lezcano
2024-08-22 16:09 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3d2c104-360a-4da0-8d77-59af89ebda2b@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).