Re: [PATCH v2 0/9] interconnect: qcom: let MSM8974 interconnect work again

Luca Weiss
2026-03-24T11:07:29Z

On Tue Mar 24, 2026 at 1:10 AM CET, Dmitry Baryshkov wrote:
> Commit d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out interconnect bus
> clocks") moved control over several RPM resources from the clk-smd-rpm
> driver to the icc-rpm.c interconnect helpers. Most of the platforms were
> fixed before that commit or shortly after. However the MSM8974 was left
> as a foster child in broken state. Fix the loose ends and reenable
> interconnects on that platform.

Thanks for taking the time to fix this, really appreciate it! I've been
carrying a partial revert of Konrad's commit for a while to get things
moving again, without taking the time to properly fix this.

I can confirm that my msm8974 phone boots fine on v7.0-rc5 with this
series and your ocmem series applied. Not much possible to test on
display/GPU since that was broken since a few releases ago. I will
probably be applying this on 6.15/6.16 branch which still had
display+GPU support.

Tested-by: Luca Weiss <luca.weiss@fairphone.com> # fairphone-fp2

Regards
Luca

>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Changes in v2:
> - Swapped order of clocks and clock-names properties (Konrad)
> - Corrected the ocmem comment regarding core clock (Konrad)
> - Link to v1: https://lore.kernel.org/r/20260323-msm8974-icc-v1-0-7892b8d5f2ea@oss.qualcomm.com
>
> ---
> Dmitry Baryshkov (9):
> dt-bindings: interconnect: qcom,msm8974: drop bus clocks
> dt-bindings: interconnect: qcom,msm8974: use qcom,rpm-common
> interconnect: qcom: drop unused is_on flag
> interconnect: qcom: icc-rpm: allow overwriting get_bw callback
> interconnect: qcom: define OCMEM bus resource
> interconnect: qcom: let platforms declare their bugginess
> interconnect: qcom: msm8974: switch to the main icc-rpm driver
> interconnect: qcom: msm8974: expand DEFINE_QNODE macros
> ARM: dts: qcom: msm8974: Drop RPM bus clocks
>
> .../bindings/interconnect/qcom,msm8974.yaml | 28 +-
> arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 21 +-
> drivers/interconnect/qcom/icc-rpm-clocks.c | 6 +
> drivers/interconnect/qcom/icc-rpm.c | 18 +-
> drivers/interconnect/qcom/icc-rpm.h | 7 +-
> drivers/interconnect/qcom/msm8974.c | 1637 +++++++++++++++-----
> 6 files changed, 1274 insertions(+), 443 deletions(-)
> ---
> base-commit: 8e5a478b6d6a5bb0a3d52147862b15e4d826af19
> change-id: 20260322-msm8974-icc-0ac4c28e139a
>
> Best regards,
> --
> With best wishes
> Dmitry