From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE66EB64DB for ; Mon, 19 Jun 2023 09:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231607AbjFSJzY (ORCPT ); Mon, 19 Jun 2023 05:55:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbjFSJzS (ORCPT ); Mon, 19 Jun 2023 05:55:18 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CB01123 for ; Mon, 19 Jun 2023 02:55:16 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b46b11051aso23151721fa.3 for ; Mon, 19 Jun 2023 02:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687168515; x=1689760515; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=eKxFvYb3cZYxLB7ZQPgBnTAZnmzpCCcSgHS68RMnZc8=; b=wH6OW839MZqfHt7yxmw/3y4XDO4pTh/dNOtvBAi85DmaChS2uPFj12uoQiW4wGJRAC Y+dHwJLDm9vEAcUzYftPE2iNCq3MoDI496/wMgPc/6aa04cdqDOKJLya8n5FsayHbg/7 uT5A+6n+U14rCuYERdGCoP96lbOqW2F43UD9dO2U5DOSxJbtJxlXU70riv//iIwBhhOP hCF9Zh6AyzpGhvR/YYW0GIOy93SqtyIA2P5THbTeA32UCAoJDn05KJzYPW+RDYKsclVr vZgZubx6xut8/oae1Zk/taJJEg0HWGb2i7bnEZnzE1ljzT0eJXV62o7RS0yOgf6Ci8aA JmJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687168515; x=1689760515; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eKxFvYb3cZYxLB7ZQPgBnTAZnmzpCCcSgHS68RMnZc8=; b=VcIhAZf8F0SQP0e/xQOu7U4r5ClUs3s6y47u4FHbrV2vTWWUk/Pt6svPia+SCrouLe j9lFYJxT6PnrEaf4zs3XFECstzS3jnMW8QJxwrktH/oi1rX5BoH8WHq/PZfiSygBW54s DfEMshKUZY1DuaCZNYZFcG6ylNWmq0uxUcXo+O7odWRliZlj6CYHom8PyhnDxu0hi5Ef AUWJYjWvAkN7LxFOf6d3+BwNiEZ/qKiRu/TfRp0OZUezjRujU9hfykdNEypGkHQ66mb7 wrR8oIQSL7Prn83jaT1H0lORWjEh3SJJvGAgpDHZ9J56I3VxXzK4OpliJ7NgMT+yNLlS C3xA== X-Gm-Message-State: AC+VfDwTCsmBzsTocSfNIdMjTqrudijjBfXOTUDxoJszl/MmJpf28sSl uTwf5x3WqtICK2lsbIoNCf+1uw== X-Google-Smtp-Source: ACHHUZ44o4fS06waGDlHtGse3+ziDgT9HAbqyNh5AapgIwJwzD4q+/XZqo1hQL8sOVMPec+8yFp06g== X-Received: by 2002:a05:6512:3285:b0:4f8:585e:5e51 with SMTP id p5-20020a056512328500b004f8585e5e51mr5022093lfe.5.1687168514616; Mon, 19 Jun 2023 02:55:14 -0700 (PDT) Received: from [192.168.1.101] (abyl242.neoplus.adsl.tpnet.pl. [83.9.31.242]) by smtp.gmail.com with ESMTPSA id r11-20020ac25a4b000000b004f391a2028dsm4207221lfn.265.2023.06.19.02.55.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 02:55:14 -0700 (PDT) Message-ID: Date: Mon, 19 Jun 2023 11:55:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Neil Armstrong , Andy Gross , Bjorn Andersson , Georgi Djakov Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230619-topic-sm8550-upstream-interconnect-mask-vote-v1-0-66663c0aa592@linaro.org> <20230619-topic-sm8550-upstream-interconnect-mask-vote-v1-2-66663c0aa592@linaro.org> From: Konrad Dybcio Subject: Re: [PATCH 2/2] interconnect: qcom: sm8550: add enable_mask for bcm nodes In-Reply-To: <20230619-topic-sm8550-upstream-interconnect-mask-vote-v1-2-66663c0aa592@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 19.06.2023 10:24, Neil Armstrong wrote: > Set the proper enable_mask to needs requiring such value > to be used instead of a bandwidth when voting. > > The masks were copied from the downstream implementation at [1]. > > [1] https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/blob/kernel.lnx.5.15.r1-rel/drivers/interconnect/qcom/kalama.c > > Signed-off-by: Neil Armstrong > --- The values match downstream, so: Reviewed-by: Konrad Dybcio Since you're already touching this code, may I turn your interest to: 1. Adding enable_mask-s to 8450 and 8775 2. Porting https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/d5edeca085f4 3. Adding the default perf settings for 8450 and 8550 Konrad > drivers/interconnect/qcom/sm8550.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/interconnect/qcom/sm8550.c b/drivers/interconnect/qcom/sm8550.c > index d823ba988ef6..0864ed285375 100644 > --- a/drivers/interconnect/qcom/sm8550.c > +++ b/drivers/interconnect/qcom/sm8550.c > @@ -1473,6 +1473,7 @@ static struct qcom_icc_node qns_mem_noc_sf_cam_ife_2 = { > > static struct qcom_icc_bcm bcm_acv = { > .name = "ACV", > + .enable_mask = 0x8, > .num_nodes = 1, > .nodes = { &ebi }, > }; > @@ -1485,6 +1486,7 @@ static struct qcom_icc_bcm bcm_ce0 = { > > static struct qcom_icc_bcm bcm_cn0 = { > .name = "CN0", > + .enable_mask = 0x1, > .keepalive = true, > .num_nodes = 54, > .nodes = { &qsm_cfg, &qhs_ahb2phy0, > @@ -1524,6 +1526,7 @@ static struct qcom_icc_bcm bcm_cn1 = { > > static struct qcom_icc_bcm bcm_co0 = { > .name = "CO0", > + .enable_mask = 0x1, > .num_nodes = 2, > .nodes = { &qxm_nsp, &qns_nsp_gemnoc }, > }; > @@ -1549,6 +1552,7 @@ static struct qcom_icc_bcm bcm_mm0 = { > > static struct qcom_icc_bcm bcm_mm1 = { > .name = "MM1", > + .enable_mask = 0x1, > .num_nodes = 8, > .nodes = { &qnm_camnoc_hf, &qnm_camnoc_icp, > &qnm_camnoc_sf, &qnm_vapss_hcp, > @@ -1589,6 +1593,7 @@ static struct qcom_icc_bcm bcm_sh0 = { > > static struct qcom_icc_bcm bcm_sh1 = { > .name = "SH1", > + .enable_mask = 0x1, > .num_nodes = 13, > .nodes = { &alm_gpu_tcu, &alm_sys_tcu, > &chm_apps, &qnm_gpu, > @@ -1608,6 +1613,7 @@ static struct qcom_icc_bcm bcm_sn0 = { > > static struct qcom_icc_bcm bcm_sn1 = { > .name = "SN1", > + .enable_mask = 0x1, > .num_nodes = 3, > .nodes = { &qhm_gic, &xm_gic, > &qns_gemnoc_gc }, > @@ -1633,6 +1639,7 @@ static struct qcom_icc_bcm bcm_sn7 = { > > static struct qcom_icc_bcm bcm_acv_disp = { > .name = "ACV", > + .enable_mask = 0x1, > .num_nodes = 1, > .nodes = { &ebi_disp }, > }; > @@ -1657,12 +1664,14 @@ static struct qcom_icc_bcm bcm_sh0_disp = { > > static struct qcom_icc_bcm bcm_sh1_disp = { > .name = "SH1", > + .enable_mask = 0x1, > .num_nodes = 2, > .nodes = { &qnm_mnoc_hf_disp, &qnm_pcie_disp }, > }; > > static struct qcom_icc_bcm bcm_acv_cam_ife_0 = { > .name = "ACV", > + .enable_mask = 0x0, > .num_nodes = 1, > .nodes = { &ebi_cam_ife_0 }, > }; > @@ -1681,6 +1690,7 @@ static struct qcom_icc_bcm bcm_mm0_cam_ife_0 = { > > static struct qcom_icc_bcm bcm_mm1_cam_ife_0 = { > .name = "MM1", > + .enable_mask = 0x1, > .num_nodes = 4, > .nodes = { &qnm_camnoc_hf_cam_ife_0, &qnm_camnoc_icp_cam_ife_0, > &qnm_camnoc_sf_cam_ife_0, &qns_mem_noc_sf_cam_ife_0 }, > @@ -1694,6 +1704,7 @@ static struct qcom_icc_bcm bcm_sh0_cam_ife_0 = { > > static struct qcom_icc_bcm bcm_sh1_cam_ife_0 = { > .name = "SH1", > + .enable_mask = 0x1, > .num_nodes = 3, > .nodes = { &qnm_mnoc_hf_cam_ife_0, &qnm_mnoc_sf_cam_ife_0, > &qnm_pcie_cam_ife_0 }, > @@ -1701,6 +1712,7 @@ static struct qcom_icc_bcm bcm_sh1_cam_ife_0 = { > > static struct qcom_icc_bcm bcm_acv_cam_ife_1 = { > .name = "ACV", > + .enable_mask = 0x0, > .num_nodes = 1, > .nodes = { &ebi_cam_ife_1 }, > }; > @@ -1719,6 +1731,7 @@ static struct qcom_icc_bcm bcm_mm0_cam_ife_1 = { > > static struct qcom_icc_bcm bcm_mm1_cam_ife_1 = { > .name = "MM1", > + .enable_mask = 0x1, > .num_nodes = 4, > .nodes = { &qnm_camnoc_hf_cam_ife_1, &qnm_camnoc_icp_cam_ife_1, > &qnm_camnoc_sf_cam_ife_1, &qns_mem_noc_sf_cam_ife_1 }, > @@ -1732,6 +1745,7 @@ static struct qcom_icc_bcm bcm_sh0_cam_ife_1 = { > > static struct qcom_icc_bcm bcm_sh1_cam_ife_1 = { > .name = "SH1", > + .enable_mask = 0x1, > .num_nodes = 3, > .nodes = { &qnm_mnoc_hf_cam_ife_1, &qnm_mnoc_sf_cam_ife_1, > &qnm_pcie_cam_ife_1 }, > @@ -1739,6 +1753,7 @@ static struct qcom_icc_bcm bcm_sh1_cam_ife_1 = { > > static struct qcom_icc_bcm bcm_acv_cam_ife_2 = { > .name = "ACV", > + .enable_mask = 0x0, > .num_nodes = 1, > .nodes = { &ebi_cam_ife_2 }, > }; > @@ -1757,6 +1772,7 @@ static struct qcom_icc_bcm bcm_mm0_cam_ife_2 = { > > static struct qcom_icc_bcm bcm_mm1_cam_ife_2 = { > .name = "MM1", > + .enable_mask = 0x1, > .num_nodes = 4, > .nodes = { &qnm_camnoc_hf_cam_ife_2, &qnm_camnoc_icp_cam_ife_2, > &qnm_camnoc_sf_cam_ife_2, &qns_mem_noc_sf_cam_ife_2 }, > @@ -1770,6 +1786,7 @@ static struct qcom_icc_bcm bcm_sh0_cam_ife_2 = { > > static struct qcom_icc_bcm bcm_sh1_cam_ife_2 = { > .name = "SH1", > + .enable_mask = 0x1, > .num_nodes = 3, > .nodes = { &qnm_mnoc_hf_cam_ife_2, &qnm_mnoc_sf_cam_ife_2, > &qnm_pcie_cam_ife_2 }, >