* [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version @ 2023-09-17 21:29 Doug Smythies 2023-09-18 0:57 ` Mario Limonciello 2023-09-18 3:41 ` [PATCH v2] " Doug Smythies 0 siblings, 2 replies; 8+ messages in thread From: Doug Smythies @ 2023-09-17 21:29 UTC (permalink / raw) To: 'Srinivas Pandruvada', rafael.j.wysocki Cc: Doug Smythies, linux-pm, linux-kernel, Mario.Limonciello, 'Swapnil Sapkal', Ray.Huang From: Doug Smythies <dsmythies@telus.net> Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line. Signed-off-by: Doug Smythies <dsmythies@telus.net> --- .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py index ec3323100e1a..6b0790e6465a 100755 --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- # @@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + phython3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) @@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os @@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability. -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-17 21:29 [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version Doug Smythies @ 2023-09-18 0:57 ` Mario Limonciello 2023-09-18 3:41 ` Doug Smythies 2023-09-18 3:41 ` [PATCH v2] " Doug Smythies 1 sibling, 1 reply; 8+ messages in thread From: Mario Limonciello @ 2023-09-18 0:57 UTC (permalink / raw) To: Doug Smythies, 'Srinivas Pandruvada', rafael.j.wysocki Cc: linux-pm, linux-kernel, 'Swapnil Sapkal', Ray.Huang On 9/17/2023 16:29, Doug Smythies wrote: > From: Doug Smythies <dsmythies@telus.net> > > Change the minimum python version from 2.7 to 3.6. > Remove a 2.X backwards compatibility line. > > Signed-off-by: Doug Smythies <dsmythies@telus.net> > --- > .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > index ec3323100e1a..6b0790e6465a 100755 > --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > # SPDX-License-Identifier: GPL-2.0-only > # -*- coding: utf-8 -*- > # > @@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval > and generates performance plots. > > Prerequisites: > - Python version 2.7.x or higher > + Python version 3.6.x or higher > gnuplot 5.0 or higher > - gnuplot-py 1.8 or higher > + phython3-gnuplot 1.8 or higher Presumably you mean 'python3-gnuplot'. > (Most of the distributions have these required packages. They may be called > gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) > Likewise here too. > @@ -23,7 +23,7 @@ Prerequisites: > see print_help(): for Usage and Output details > > """ > -from __future__ import print_function > + > from datetime import datetime > import subprocess > import os > @@ -562,7 +562,7 @@ if __name__ == "__main__": > > # Temporary (or perhaps not) > cur_version = sys.version_info > - print('python version (should be >= 2.7):') > + print('python version (should be >= 3.6):') > print(cur_version) Is this block printing the version really needed at all? I don't see 'cur_version' used anywhere else in the file. > > # Left as "cleanup" for potential future re-run ability. > -- > 2.25.1 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-18 0:57 ` Mario Limonciello @ 2023-09-18 3:41 ` Doug Smythies 0 siblings, 0 replies; 8+ messages in thread From: Doug Smythies @ 2023-09-18 3:41 UTC (permalink / raw) To: 'Mario Limonciello' Cc: linux-pm, linux-kernel, 'Swapnil Sapkal', Ray.Huang, 'Srinivas Pandruvada', rafael.j.wysocki, Doug Smythies On 2023.09.17 17:57 Mario wrote: > On 9/17/2023 16:29, Doug Smythies wrote: >> From: Doug Smythies <dsmythies@telus.net> >> >> Change the minimum python version from 2.7 to 3.6. >> Remove a 2.X backwards compatibility line. >> >> Signed-off-by: Doug Smythies <dsmythies@telus.net> >> --- >> .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py >> index ec3323100e1a..6b0790e6465a 100755 >> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py >> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py >> @@ -1,4 +1,4 @@ >> -#!/usr/bin/env python >> +#!/usr/bin/env python3 >> # SPDX-License-Identifier: GPL-2.0-only >> # -*- coding: utf-8 -*- >> # >> @@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval >> and generates performance plots. >> >> Prerequisites: >> - Python version 2.7.x or higher >> + Python version 3.6.x or higher >> gnuplot 5.0 or higher >> - gnuplot-py 1.8 or higher >> + phython3-gnuplot 1.8 or higher > > Presumably you mean 'python3-gnuplot'. Oh Darn. Yes. I'll send a V2. >> (Most of the distributions have these required packages. They may be called >> gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) >> > > Likewise here too. > >> @@ -23,7 +23,7 @@ Prerequisites: >> see print_help(): for Usage and Output details >> >> """ >> -from __future__ import print_function >> + >> from datetime import datetime >> import subprocess >> import os >> @@ -562,7 +562,7 @@ if __name__ == "__main__": >> >> # Temporary (or perhaps not) >> cur_version = sys.version_info >> - print('python version (should be >= 2.7):') >> + print('python version (should be >= 3.6):') >> print(cur_version) > > Is this block printing the version really needed at all? > I don't see 'cur_version' used anywhere else in the file. Well, it is there to make it easy to know what the requirements are and what the actual version is. The minimum version is not enforced. >> # Left as "cleanup" for potential future re-run ability. >> -- >> 2.25.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-17 21:29 [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version Doug Smythies 2023-09-18 0:57 ` Mario Limonciello @ 2023-09-18 3:41 ` Doug Smythies 2023-09-18 4:03 ` [PATCH v3] " Doug Smythies 1 sibling, 1 reply; 8+ messages in thread From: Doug Smythies @ 2023-09-18 3:41 UTC (permalink / raw) To: 'Srinivas Pandruvada', rafael.j.wysocki Cc: linux-pm, linux-kernel, Mario.Limonciello, 'Swapnil Sapkal', Ray.Huang, Doug Smythies From: Doug Smythies <dsmythies@telus.net> Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line. Signed-off-by: Doug Smythies <dsmythies@telus.net> --- v1 -> v2: Fix careless typos. --- .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py index ec3323100e1a..6b0790e6465a 100755 --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- # @@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + python3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) @@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os @@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability. -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v3] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-18 3:41 ` [PATCH v2] " Doug Smythies @ 2023-09-18 4:03 ` Doug Smythies 2023-09-18 17:25 ` srinivas pandruvada ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Doug Smythies @ 2023-09-18 4:03 UTC (permalink / raw) To: 'Srinivas Pandruvada', rafael.j.wysocki Cc: linux-pm, linux-kernel, Mario.Limonciello, 'Swapnil Sapkal', Ray.Huang, Doug Smythies From: Doug Smythies <dsmythies@telus.net> Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line. Signed-off-by: Doug Smythies <dsmythies@telus.net> --- v2 -> v3: Try to fix mess that was v2. v1 -> v2: Fix careless typos. --- .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py index ec3323100e1a..38cfbdcdedb7 100755 --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- # @@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + python3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) HWP (Hardware P-States are disabled) Kernel config for Linux trace is enabled @@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os @@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability. -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-18 4:03 ` [PATCH v3] " Doug Smythies @ 2023-09-18 17:25 ` srinivas pandruvada 2023-09-18 17:35 ` Mario Limonciello 2023-09-19 7:40 ` Swapnil Sapkal 2 siblings, 0 replies; 8+ messages in thread From: srinivas pandruvada @ 2023-09-18 17:25 UTC (permalink / raw) To: Doug Smythies, rafael.j.wysocki Cc: linux-pm, linux-kernel, Mario.Limonciello, 'Swapnil Sapkal', Ray.Huang On Sun, 2023-09-17 at 21:03 -0700, Doug Smythies wrote: > Think somehow one extra new line in email. > From: Doug Smythies <dsmythies@telus.net> > > Change the minimum python version from 2.7 to 3.6. > Remove a 2.X backwards compatibility line. > > Signed-off-by: Doug Smythies <dsmythies@telus.net> Acked-by: Srinivas Pandruvada<srinivas.pandruvada@linux.intel.com> > --- > > v2 -> v3: Try to fix mess that was v2. > v1 -> v2: Fix careless typos. > > --- > .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++----- > - > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git > a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > index ec3323100e1a..38cfbdcdedb7 100755 > --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > # SPDX-License-Identifier: GPL-2.0-only > # -*- coding: utf-8 -*- > # > @@ -11,11 +11,11 @@ then this utility enables and collects trace data > for a user specified interval > and generates performance plots. > > Prerequisites: > - Python version 2.7.x or higher > + Python version 3.6.x or higher > gnuplot 5.0 or higher > - gnuplot-py 1.8 or higher > + python3-gnuplot 1.8 or higher > (Most of the distributions have these required packages. They > may be called > - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, > ... ) > + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... > ) > > HWP (Hardware P-States are disabled) > Kernel config for Linux trace is enabled > @@ -23,7 +23,7 @@ Prerequisites: > see print_help(): for Usage and Output details > > """ > -from __future__ import print_function > + > from datetime import datetime > import subprocess > import os > @@ -562,7 +562,7 @@ if __name__ == "__main__": > > # Temporary (or perhaps not) > cur_version = sys.version_info > - print('python version (should be >= 2.7):') > + print('python version (should be >= 3.6):') > print(cur_version) > > # Left as "cleanup" for potential future re-run ability. > -- > 2.25.1 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-18 4:03 ` [PATCH v3] " Doug Smythies 2023-09-18 17:25 ` srinivas pandruvada @ 2023-09-18 17:35 ` Mario Limonciello 2023-09-19 7:40 ` Swapnil Sapkal 2 siblings, 0 replies; 8+ messages in thread From: Mario Limonciello @ 2023-09-18 17:35 UTC (permalink / raw) To: Doug Smythies, 'Srinivas Pandruvada', rafael.j.wysocki Cc: linux-pm, linux-kernel, 'Swapnil Sapkal', Ray.Huang On 9/17/2023 23:03, Doug Smythies wrote: > > From: Doug Smythies <dsmythies@telus.net> > > Change the minimum python version from 2.7 to 3.6. > Remove a 2.X backwards compatibility line. > > Signed-off-by: Doug Smythies <dsmythies@telus.net> > --- > > v2 -> v3: Try to fix mess that was v2. > v1 -> v2: Fix careless typos. > > --- > .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > index ec3323100e1a..38cfbdcdedb7 100755 > --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > # SPDX-License-Identifier: GPL-2.0-only > # -*- coding: utf-8 -*- > # > @@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval > and generates performance plots. > > Prerequisites: > - Python version 2.7.x or higher > + Python version 3.6.x or higher > gnuplot 5.0 or higher > - gnuplot-py 1.8 or higher > + python3-gnuplot 1.8 or higher > (Most of the distributions have these required packages. They may be called > - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) > + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) > > HWP (Hardware P-States are disabled) > Kernel config for Linux trace is enabled > @@ -23,7 +23,7 @@ Prerequisites: > see print_help(): for Usage and Output details > > """ > -from __future__ import print_function > + > from datetime import datetime > import subprocess > import os > @@ -562,7 +562,7 @@ if __name__ == "__main__": > > # Temporary (or perhaps not) > cur_version = sys.version_info > - print('python version (should be >= 2.7):') > + print('python version (should be >= 3.6):') > print(cur_version) > > # Left as "cleanup" for potential future re-run ability. > -- > 2.25.1 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] tools/power/x86/intel_pstate_tracer: python minimum version 2023-09-18 4:03 ` [PATCH v3] " Doug Smythies 2023-09-18 17:25 ` srinivas pandruvada 2023-09-18 17:35 ` Mario Limonciello @ 2023-09-19 7:40 ` Swapnil Sapkal 2 siblings, 0 replies; 8+ messages in thread From: Swapnil Sapkal @ 2023-09-19 7:40 UTC (permalink / raw) To: Doug Smythies, 'Srinivas Pandruvada', rafael.j.wysocki Cc: linux-pm, linux-kernel, Mario.Limonciello, Ray.Huang On 9/18/2023 9:33 AM, Doug Smythies wrote: > > From: Doug Smythies <dsmythies@telus.net> > > Change the minimum python version from 2.7 to 3.6. > Remove a 2.X backwards compatibility line. > > Signed-off-by: Doug Smythies <dsmythies@telus.net> > --- > > v2 -> v3: Try to fix mess that was v2. > v1 -> v2: Fix careless typos. > > --- > .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Tested-by: Swapnil Sapkal <Swapnil.Sapkal@amd.com> > diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > index ec3323100e1a..38cfbdcdedb7 100755 > --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > # SPDX-License-Identifier: GPL-2.0-only > # -*- coding: utf-8 -*- > # > @@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval > and generates performance plots. > > Prerequisites: > - Python version 2.7.x or higher > + Python version 3.6.x or higher > gnuplot 5.0 or higher > - gnuplot-py 1.8 or higher > + python3-gnuplot 1.8 or higher > (Most of the distributions have these required packages. They may be called > - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) > + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) > > HWP (Hardware P-States are disabled) > Kernel config for Linux trace is enabled > @@ -23,7 +23,7 @@ Prerequisites: > see print_help(): for Usage and Output details > > """ > -from __future__ import print_function > + > from datetime import datetime > import subprocess > import os > @@ -562,7 +562,7 @@ if __name__ == "__main__": > > # Temporary (or perhaps not) > cur_version = sys.version_info > - print('python version (should be >= 2.7):') > + print('python version (should be >= 3.6):') > print(cur_version) > > # Left as "cleanup" for potential future re-run ability. > -- > 2.25.1 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-09-19 7:40 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-17 21:29 [PATCH] tools/power/x86/intel_pstate_tracer: python minimum version Doug Smythies 2023-09-18 0:57 ` Mario Limonciello 2023-09-18 3:41 ` Doug Smythies 2023-09-18 3:41 ` [PATCH v2] " Doug Smythies 2023-09-18 4:03 ` [PATCH v3] " Doug Smythies 2023-09-18 17:25 ` srinivas pandruvada 2023-09-18 17:35 ` Mario Limonciello 2023-09-19 7:40 ` Swapnil Sapkal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).