From: Xiaojian Du <xiaojidu@amd.com>
To: Dave Hansen <dave.hansen@intel.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pm@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
daniel.sneddon@linux.intel.com, jpoimboe@kernel.org,
pawan.kumar.gupta@linux.intel.com, sandipan.das@amd.com,
kai.huang@intel.com, ray.huang@amd.com, rafael@kernel.org,
Perry.Yuan@amd.com, gautham.shenoy@amd.com,
Borislav.Petkov@amd.com, mario.limonciello@amd.com
Subject: Re: [PATCH v3 1/2] x86/cpufeatures: Add AMD FAST CPPC feature flag
Date: Mon, 27 May 2024 22:36:57 +0800 [thread overview]
Message-ID: <f59f4cc3-6327-2f1e-dc32-03eeaffe1f54@amd.com> (raw)
In-Reply-To: <5c14a151-25c9-41f5-af65-d2a8ffe548fa@intel.com>
Thanks Dave.
Because "CPPC" has existed in the "cpufeatures.h", thinking it will add
duplicated line so I don't expand it.
Making this new flag hidden is to avoid causing user confusion about two
"CPPC" flags.
This new feature flag is added to choose code branch, if not, it has to
choose a ugly way and use CPU model ID.
Thanks,
Xiaojian
On 2024/5/24 0:31, Dave Hansen wrote:
> On 5/22/24 23:16, Xiaojian Du wrote:
>> #define X86_FEATURE_BHI_CTRL (21*32+ 2) /* "" BHI_DIS_S HW control available */
>> #define X86_FEATURE_CLEAR_BHB_HW (21*32+ 3) /* "" BHI_DIS_S HW control enabled */
>> #define X86_FEATURE_CLEAR_BHB_LOOP_ON_VMEXIT (21*32+ 4) /* "" Clear branch history at vmexit using SW loop */
>> +#define X86_FEATURE_FAST_CPPC (21*32 + 5) /* "" AMD Fast CPPC */
> It'd be nice to expand the CPPC acronym at least _once_.
>
> Also, this is used _once_ at boot and not exposed in /proc/cpuinfo. Is
> it even worth defining an X86_FEATURE_ for it?
next prev parent reply other threads:[~2024-05-27 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 6:16 [PATCH v3 1/2] x86/cpufeatures: Add AMD FAST CPPC feature flag Xiaojian Du
2024-05-23 6:16 ` [PATCH v3 2/2] cpufreq: amd-pstate: change cpu freq transition delay for some models Xiaojian Du
2024-05-23 6:17 ` Xiaojian Du
2024-05-23 6:16 ` [PATCH v3 1/2] x86/cpufeatures: Add AMD FAST CPPC feature flag Xiaojian Du
2024-05-23 16:31 ` Dave Hansen
2024-05-27 14:36 ` Xiaojian Du [this message]
2024-05-23 22:24 ` Pawan Gupta
2024-05-23 22:35 ` Pawan Gupta
2024-05-27 14:40 ` Xiaojian Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59f4cc3-6327-2f1e-dc32-03eeaffe1f54@amd.com \
--to=xiaojidu@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=sandipan.das@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox