From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com,
sboyd@kernel.org, mka@chromium.org, dianders@chromium.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [[PATCH v2 2/2] OPP: Add 'opp-microwatt' parsing for advanced EM registration
Date: Wed, 23 Feb 2022 09:13:11 +0000 [thread overview]
Message-ID: <f6b2f524-6355-5f18-0358-6b6f96142b04@arm.com> (raw)
In-Reply-To: <20220223091012.w3flzpye6z55jnwd@vireshk-i7>
On 2/23/22 09:10, Viresh Kumar wrote:
> On 23-02-22, 08:59, Lukasz Luba wrote:
>> OK, so you want to have this available for the whole system. I can do
>> that. I would go for one value of power
>
> One value per supply, right ?
yes, only the u_watt, no _min, _max variants.
>
>> and try to fit into the
>> opp_parse_supplies() code.
>
> Correct.
>
>> As far as I can see in the
>> dev_pm_opp_get_voltage() the simple solution: supplier[0] and u_volt
>> is used. I would go for similar solution for u_watt.
>> There is even a single u_amp and no _max, _min variants, so should be
>> good..
>
> Yes, I don't think we need min/max/target kind of naming here. Just a single
> value per supply is enough.
>
Good, thanks for comments. Let me craft the v3 then.
next prev parent reply other threads:[~2022-02-23 9:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 14:07 [PATCH v2 0/2] Introduce 'advanced' Energy Model in DT Lukasz Luba
2022-02-22 14:07 ` [[PATCH v2 1/2] dt-bindings: opp: Add 'opp-microwatt' entry in the OPP Lukasz Luba
2022-02-23 5:50 ` Viresh Kumar
2022-02-23 8:39 ` Lukasz Luba
2022-02-23 8:45 ` Viresh Kumar
2022-02-22 14:07 ` [[PATCH v2 2/2] OPP: Add 'opp-microwatt' parsing for advanced EM registration Lukasz Luba
2022-02-22 14:58 ` Matthias Kaehlcke
2022-02-22 15:21 ` Lukasz Luba
2022-02-23 5:53 ` Viresh Kumar
2022-02-23 8:59 ` Lukasz Luba
2022-02-23 9:10 ` Viresh Kumar
2022-02-23 9:13 ` Lukasz Luba [this message]
2022-02-23 9:52 ` [PATCH v2 0/2] Introduce 'advanced' Energy Model in DT Daniel Lezcano
2022-02-23 10:16 ` Lukasz Luba
2022-02-23 10:43 ` Viresh Kumar
2022-02-23 11:22 ` Lukasz Luba
2022-02-23 11:27 ` Viresh Kumar
2022-02-23 11:40 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b2f524-6355-5f18-0358-6b6f96142b04@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox