From: Lukasz Luba <lukasz.luba@arm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
daniel.lezcano@linaro.org, rafael@kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] powercap: DTPM: Fix the missing cpufreq_cpu_put() calls
Date: Fri, 1 Dec 2023 14:02:38 +0000 [thread overview]
Message-ID: <f6d9b092-20e8-436e-9307-2c24cb0ba3a5@arm.com> (raw)
In-Reply-To: <2023120139-staging-sprang-7e77@gregkh>
Hi Greg,
On 12/1/23 12:44, Greg KH wrote:
> On Fri, Dec 01, 2023 at 12:32:05PM +0000, Lukasz Luba wrote:
>> The policy returned by cpufreq_cpu_get() has to be released with
>> the help of cpufreq_cpu_put() to balance its kobject reference counter
>> properly.
>>
>> Add the missing calls to cpufreq_cpu_put() in the code.
>>
>> Fixes: 0aea2e4ec2a2 ("powercap/dtpm_cpu: Reset per_cpu variable in the release function")
>> Fixes: 0e8f68d7f048 ("powercap/drivers/dtpm: Add CPU energy model based support")
>> Cc: <stable@vger.kernel.org> # v5.10+
>
> But the Fixes: tags are for commits that are only in 5.12 and newer, how
> can this be relevant for 5.10?
My apologies, you're right. Somehow I checked that this dtpm_cpu.c
was introduced in v5.10. It was in v5.12 indeed. I messed that up.
Also, the code in that v5.12 had different implementation and there was
a function cpuhp_dtpm_cpu_offline() which had the cpufreq_cpu_get().
I can craft for that v5.12 special extra patch fix addressing it and
send directly to stable list. Would that make sense?
So this patch would only be applicable for v5.16+ AFAICS.
Regards,
Lukasz
next prev parent reply other threads:[~2023-12-01 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 12:32 [PATCH] powercap: DTPM: Fix the missing cpufreq_cpu_put() calls Lukasz Luba
2023-12-01 12:44 ` Greg KH
2023-12-01 14:02 ` Lukasz Luba [this message]
2023-12-05 19:54 ` Rafael J. Wysocki
2023-12-06 13:12 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6d9b092-20e8-436e-9307-2c24cb0ba3a5@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox