From: Shuah <shuah@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>,
Julia.Lawall@inria.fr, Thomas Renninger <trenn@suse.com>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 35/36] cpupower: remove conditional return with no effect
Date: Tue, 4 Aug 2026 13:15:22 -0600 [thread overview]
Message-ID: <f8a89cd1-eb4f-40f7-8556-2f4d689a293a@kernel.org> (raw)
In-Reply-To: <20260723184538.3888637-36-ekffu200098@gmail.com>
On 7/23/26 12:45, Sang-Heon Jeon wrote:
> Both branches of the check return the same value, so the check has
> no effect. Remove it and return the value directly.
>
> This is the result of running the Coccinelle script from
> scripts/coccinelle/misc/cond_return_no_effect.cocci.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Applied to
https://web.git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower
Will include it in my next pr to PM maintainer.
thanks,
-- Shuah
next prev parent reply other threads:[~2026-08-04 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:45 [PATCH 00/36] treewide: remove conditional returns with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 26/36] power: supply: pm8916_lbc: remove conditional return " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 31/36] thermal/drivers/k3_bandgap: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 35/36] cpupower: " Sang-Heon Jeon
2026-08-04 19:15 ` Shuah [this message]
2026-07-24 21:48 ` [PATCH 00/36] treewide: remove conditional returns " Jakub Kicinski
2026-07-27 8:30 ` Jani Nikula
2026-07-27 11:08 ` Sang-Heon Jeon
2026-07-27 11:36 ` Jani Nikula
2026-07-24 23:35 ` (subset) " Sebastian Reichel
2026-07-27 12:12 ` Mark Brown
2026-07-27 12:59 ` Sang-Heon Jeon
2026-07-27 12:26 ` (subset) " Mark Brown
2026-08-06 19:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a89cd1-eb4f-40f7-8556-2f4d689a293a@kernel.org \
--to=shuah@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=ekffu200098@gmail.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox