From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, rafael@kernel.org, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
dave.hansen@linux.intel.com, tglx@linutronix.de, andi@lisas.de,
puwen@hygon.cn, mario.limonciello@amd.com, peterz@infradead.org,
rui.zhang@intel.com, gpiccoli@igalia.com,
daniel.lezcano@linaro.org, ananth.narayan@amd.com,
gautham.shenoy@amd.com, Calvin Ong <calvin.ong@amd.com>,
stable@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] ACPI: processor_idle: Skip dummy wait for processors based on the Zen microarchitecture
Date: Wed, 21 Sep 2022 16:09:16 +0530 [thread overview]
Message-ID: <f927f969-028a-4ad4-7776-527ed537c77f@amd.com> (raw)
In-Reply-To: <YyrPqlo/ysCeh4qU@zn.tnic>
Hello Boris,
On 9/21/2022 2:17 PM, Borislav Petkov wrote:
> On Wed, Sep 21, 2022 at 12:06:38PM +0530, K Prateek Nayak wrote:
>> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
>> index 16a1663d02d4..18850aa2b79b 100644
>> --- a/drivers/acpi/processor_idle.c
>> +++ b/drivers/acpi/processor_idle.c
>> @@ -528,8 +528,11 @@ static int acpi_idle_bm_check(void)
>> static void wait_for_freeze(void)
>> {
>> #ifdef CONFIG_X86
>> - /* No delay is needed if we are in guest */
>> - if (boot_cpu_has(X86_FEATURE_HYPERVISOR))
>> + /*
>> + * No delay is needed if we are in guest or on a processor
>> + * based on the Zen microarchitecture.
>> + */
>> + if (boot_cpu_has(X86_FEATURE_HYPERVISOR) || boot_cpu_has(X86_FEATURE_ZEN))
>
> s/boot_cpu_has/cpu_feature_enabled/g
I was not aware of cpu_feature_enabled() and it makes perfect sense to
use it here. Thank you for bringing it to my notice.
I'll make this change in v2.
>
> while at it.
>
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2022-09-21 10:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 6:36 [PATCH] ACPI: processor_idle: Skip dummy wait for processors based on the Zen microarchitecture K Prateek Nayak
2022-09-21 8:47 ` Borislav Petkov
2022-09-21 10:39 ` K Prateek Nayak [this message]
2022-09-21 13:10 ` Borislav Petkov
2022-09-21 14:15 ` Dave Hansen
2022-09-21 19:51 ` Borislav Petkov
2022-09-21 19:55 ` Limonciello, Mario
2022-09-22 3:58 ` Ananth Narayan
2022-09-22 5:44 ` K Prateek Nayak
[not found] ` <20220923160106.9297-1-ermorton@ericmoronsm1mbp.amd.com>
2022-09-23 16:15 ` Ananth Narayan
2022-09-21 15:00 ` Peter Zijlstra
2022-09-21 19:48 ` Borislav Petkov
2022-09-22 8:17 ` Peter Zijlstra
2022-09-22 15:21 ` Rafael J. Wysocki
2022-09-22 15:36 ` Borislav Petkov
2022-09-22 15:53 ` Rafael J. Wysocki
2022-09-22 16:36 ` Dave Hansen
2022-09-22 16:44 ` Dave Hansen
2022-09-22 16:54 ` K Prateek Nayak
2022-09-22 17:01 ` Dave Hansen
2022-09-22 17:48 ` Limonciello, Mario
2022-09-22 18:17 ` Dave Hansen
2022-09-22 18:28 ` Limonciello, Mario
2022-09-23 11:47 ` Ananth Narayan
2022-09-22 19:42 ` Andreas Mohr
2022-09-22 20:10 ` Andreas Mohr
2022-09-22 21:21 ` Dave Hansen
2022-09-22 21:38 ` Limonciello, Mario
2022-09-23 7:42 ` Peter Zijlstra
2022-09-23 7:57 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f927f969-028a-4ad4-7776-527ed537c77f@amd.com \
--to=kprateek.nayak@amd.com \
--cc=ananth.narayan@amd.com \
--cc=andi@lisas.de \
--cc=bp@alien8.de \
--cc=calvin.ong@amd.com \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=gpiccoli@igalia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=peterz@infradead.org \
--cc=puwen@hygon.cn \
--cc=rafael@kernel.org \
--cc=regressions@lists.linux.dev \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox