From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Len Brown <lenb@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org,
Artem Bityutskiy <artem.bityutskiy@intel.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Allow repeated intel_pstate disable
Date: Thu, 05 Mar 2026 13:50:43 -0800 [thread overview]
Message-ID: <f9a7677b7ac4a85f77a438cd08e02c4fe7ea6ff6.camel@linux.intel.com> (raw)
In-Reply-To: <20260219181600.16388-1-fabio.m.de.francesco@linux.intel.com>
On Thu, 2026-02-19 at 19:15 +0100, Fabio M. De Francesco wrote:
> Repeated intel_pstate disables currently return an error, adding
> unnecessary
> complexity to userspace scripts which must first read the current
> state and
> conditionally write 'off'.
>
> Make repeated intel_pstate disables a no-op.
>
> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
> Signed-off-by: Fabio M. De Francesco
> <fabio.m.de.francesco@linux.intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 1625ec2d0d06..d639cc150092 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -3470,7 +3470,7 @@ static int intel_pstate_update_status(const
> char *buf, size_t size)
> {
> if (size == 3 && !strncmp(buf, "off", size)) {
> if (!intel_pstate_driver)
> - return -EINVAL;
> + return 0;
>
> if (hwp_active)
> return -EBUSY;
next prev parent reply other threads:[~2026-03-05 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 18:15 [PATCH] cpufreq: intel_pstate: Allow repeated intel_pstate disable Fabio M. De Francesco
2026-03-05 21:50 ` srinivas pandruvada [this message]
2026-03-06 18:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a7677b7ac4a85f77a438cd08e02c4fe7ea6ff6.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=artem.bityutskiy@intel.com \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox