From: Peng Fan <peng.fan@oss.nxp.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate
Date: Mon, 17 Oct 2022 16:04:56 +0800 [thread overview]
Message-ID: <f9f56c91-83b0-116d-5e5f-7a2df1e939c7@oss.nxp.com> (raw)
In-Reply-To: <20221014081620.1599511-1-marcus.folkesson@gmail.com>
On 10/14/2022 4:16 PM, Marcus Folkesson wrote:
> GENMASK() is preferred to use for bitmasks.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/thermal/imx8mm_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index c5cd873c6e01..74fc34b88bb0 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -23,8 +23,8 @@
>
> #define TER_ADC_PD BIT(30)
> #define TER_EN BIT(31)
> -#define TRITSR_TEMP0_VAL_MASK 0xff
> -#define TRITSR_TEMP1_VAL_MASK 0xff0000
> +#define TRITSR_TEMP0_VAL_MASK GENMASK(7, 0)
> +#define TRITSR_TEMP1_VAL_MASK GENMASK(23, 16)
>
> #define PROBE_SEL_ALL GENMASK(31, 30)
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
next prev parent reply other threads:[~2022-10-17 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 8:16 [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate Marcus Folkesson
2022-10-17 8:04 ` Peng Fan [this message]
2022-12-09 15:26 ` [thermal: thermal/next] thermal/drivers/imx8mm_thermal: Use " thermal-bot for Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f56c91-83b0-116d-5e5f-7a2df1e939c7@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=Anson.Huang@nxp.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox