From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F9C7C41513 for ; Tue, 25 Jul 2023 21:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231475AbjGYVEp (ORCPT ); Tue, 25 Jul 2023 17:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbjGYVEo (ORCPT ); Tue, 25 Jul 2023 17:04:44 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 119901BCD; Tue, 25 Jul 2023 14:04:41 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PKK0mn003459; Tue, 25 Jul 2023 21:04:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=RP8Tqm+PXpGb/xYfB+IPgy0qNnZ3d+KGVXRqBNWDf6k=; b=b3uIDdE6SEJQiL5n1ot1Q5NKQ137hee0vv+JhBqsFDOfkoEVMKLE67hweRoJFEAzfhzT oQJYjEIRN9bblv83bP2hBy0SzNuPZSkEBbDXASx2VrE35CscRZ0gfv/Of29kjAuH9ixf W+e7myu1ttqoLQa5bivZ4QZrqhZv02QbMFBQ91LUxi7PX8U7mZjgDRC0Y/HF6onAh2y5 p9qmfmrCw0oLLKr85o9iv4cvAMLmCrpPfhvVw9ltTLHdydWq+soobSvc0cnjo0RgMon/ 071h7hSqwLaI6jMZGKU85DHkoFkNcbwpOeiZ26SwOe0FJ5CyAAPnuBnMyg7xkfb8Y/hv aQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s2dqah92s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 21:04:31 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36PL4U8Q001854 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 21:04:30 GMT Received: from [10.71.109.50] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 25 Jul 2023 14:04:29 -0700 Message-ID: Date: Tue, 25 Jul 2023 14:04:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 2/4] power: reset: reboot-mode: Wire reboot_mode enum to magic Content-Language: en-US To: Mukesh Ojha , Mark Rutland , Lorenzo Pieralisi , Sebastian Reichel CC: Krzysztof Kozlowski , Conor Dooley , Rob Herring , , , , , , , "Satya Durga Srinivasu Prabhala" , Melody Olvera , Prasad Sodagudi References: <20230724223057.1208122-1-quic_eberman@quicinc.com> <20230724223057.1208122-3-quic_eberman@quicinc.com> <27d9bd35-b69c-5596-8e1a-c42ec2b01f75@quicinc.com> From: Elliot Berman In-Reply-To: <27d9bd35-b69c-5596-8e1a-c42ec2b01f75@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: C_kUgcfHIP1FkxbMmEOtRmBxb1-g4KbV X-Proofpoint-ORIG-GUID: C_kUgcfHIP1FkxbMmEOtRmBxb1-g4KbV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_12,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250179 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 7/25/2023 3:03 AM, Mukesh Ojha wrote: > > > On 7/25/2023 4:00 AM, Elliot Berman wrote: >> Allow the reboot mode type to be wired to magic. >> >> Signed-off-by: Elliot Berman >> --- >>   drivers/power/reset/reboot-mode.c | 30 ++++++++++++++++++++++++++---- >>   1 file changed, 26 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/power/reset/reboot-mode.c >> b/drivers/power/reset/reboot-mode.c >> index a646aefa041b..4ea97ccbaf51 100644 >> --- a/drivers/power/reset/reboot-mode.c >> +++ b/drivers/power/reset/reboot-mode.c >> @@ -22,12 +22,8 @@ struct mode_info { >>   static bool get_reboot_mode_magic(struct reboot_mode_driver *reboot, >>                         const char *cmd, unsigned int *magic) >>   { >> -    const char *normal = "normal"; >>       struct mode_info *info; >> -    if (!cmd) >> -        cmd = normal; >> - >>       list_for_each_entry(info, &reboot->head, list) { >>           if (!strcmp(info->mode, cmd)) { >>               *magic = info->magic; >> @@ -45,6 +41,32 @@ static int reboot_mode_notify(struct notifier_block >> *this, >>       unsigned int magic; >>       reboot = container_of(this, struct reboot_mode_driver, >> reboot_notifier); >> + >> +    if (!cmd) { >> +        switch (mode) { > > IIUC, mode will be filled up with reboot_mode during restart > notifier and not reboot notifiers ? > Ah, you're correct. I should register a restart notifier and not use reboot mode framework. I'll follow similar bindings. >> +        case REBOOT_COLD: >> +            cmd = "cold"; >> +            break; >> +        case REBOOT_WARM: >> +            cmd = "warm"; >> +            break; >> +        case REBOOT_HARD: >> +            cmd = "hard"; >> +            break; >> +        case REBOOT_SOFT: >> +            cmd = "soft"; >> +            break; >> +        case REBOOT_GPIO: >> +            cmd = "gpio"; > > These strings are already there kernel/reboot.c > Can it be reused ? > > #define REBOOT_COLD_STR         "cold" > #define REBOOT_WARM_STR         "warm" > #define REBOOT_HARD_STR         "hard" > #define REBOOT_SOFT_STR         "soft" > #define REBOOT_GPIO_STR         "gpio" > #define REBOOT_UNDEFINED_STR    "undefined" > > One set of constants are "binding" for devicetree and the other is for sysfs. I think they should be kept separate. >> +            break; >> +        } >> +        if (get_reboot_mode_magic(reboot, cmd, &magic)) { > > Is info->mode is going to filled up with mode-cold, mode-warm and so > on from DT to compare against cmd? > > What if , cmd is not among the one above switch, NULL pointer during > strcmp ? > > -Mukesh > >> +            reboot->write(reboot, magic); >> +            return NOTIFY_DONE; >> +        } >> +        cmd = "normal"; >> +    } >> + >>       if (get_reboot_mode_magic(reboot, cmd, &magic)) >>           reboot->write(reboot, magic);