From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8CEC433F5 for ; Sun, 15 May 2022 09:51:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236056AbiEOJuz (ORCPT ); Sun, 15 May 2022 05:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234276AbiEOJuy (ORCPT ); Sun, 15 May 2022 05:50:54 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 403FD2EA17 for ; Sun, 15 May 2022 02:50:51 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id d19so21278457lfj.4 for ; Sun, 15 May 2022 02:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=P4NpdP8gMX4y3C6YTYYB9Nre+Yy7M1p6asm/4EkODj179NE84yTYgfBRBKmG8Z7SA0 +ua4WeNEU0y+fUYbcz1fsVq6rVZkM9D+ElBVUTpacF2Rgfh2f5pXnwHtUQSlb3EVGCKh 7UthSL65O/YTpmLBRbVWkLaIb118nbb/DK9CESGDMIL1Kc5H3hUtl/54+KL6dHmx2oiI ZZhDJRQDk3A0HxN1FemJc8XmsRjhBSLMWWuV4zvea5C4vtaNOrfwhG5mPykKNCW2y44x OcEOqIUkJHeWiDivadQf0ROtZnh6CsTtQ105UIGXWmQyk37RZiIIyzpjYrgEODD/9Ox2 uMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=7tXwCKFRHE7pueoLwG+1E9OPO53+IaUx76WvnONuGf1lWkfQsr00t4nC+p8ag/AkOd Ga/+i//uJ43E7dF/PCqvHOrfnaQG24lp+NH7V051ZYbLC9RqQ1ZOVFoFJZqeOPAXGEyv MWCmFC6VlcdyP3DRrpZt2EiSiIdmVuB6v+h3lGvY1/+YqMtJdxBSBVWZ0SI62R3a6RrC 5Y7LdDFcCrrVCIyzf71LPrDp/7CQoS6dXYWSAzKYJSVUpJbXe9KmJOh052B4Mu9zdMsk GmlcFtH9HCvZuV3nHNlgv6JpMJhgxL1lpJRyzzRiYuaMC+ujFrx0RszYd9NidEUlMNyZ LREA== X-Gm-Message-State: AOAM5329Uk/eOgW1zIB/w4BxH0QY0iHBLbLdVNho5gxT3MyWdlI2cKIi A6UCrFRt+l/BNhNoXCyAHDLZTw== X-Google-Smtp-Source: ABdhPJwOLry/chcSZ6wRRTHJAPGCWa4sZSHfMWq3GnThJ/DjNvArBBCY0ab9VZbRJdVQtzEcryDExA== X-Received: by 2002:a05:6512:3993:b0:473:1953:59 with SMTP id j19-20020a056512399300b0047319530059mr9067511lfu.269.1652608249643; Sun, 15 May 2022 02:50:49 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d21-20020a2e96d5000000b0024f3d1daec7sm1129326ljj.79.2022.05.15.02.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 May 2022 02:50:49 -0700 (PDT) Message-ID: Date: Sun, 15 May 2022 11:50:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCHv2 2/6] thermal: exynos: Reorder the gpu clock initialization for exynos5420 SoC Content-Language: en-US To: Anand Moon , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-3-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220515064126.1424-3-linux.amoon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 15/05/2022 08:41, Anand Moon wrote: > Reorder the tmu_gpu clock initialization for exynos5422 SoC. Some more thoughts: where is the GPU here? This is a TMU driver... In subject you also describe GPU. My comments about unusual code order from [1] were not answered. https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#m3edd1fa357eb3e921e51eb09e2e32d68496332eb Please respond/address to all comments before resending. Best regards, Krzysztof