From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com,
mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org,
daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
corbet@lwn.net, gregkh@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Cc: qyousef@layalina.io
Subject: Re: [PATCH v3 2/5] sched: Take cpufreq feedback into account
Date: Tue, 9 Jan 2024 12:22:01 +0100 [thread overview]
Message-ID: <fb25afab-9586-455a-b8c1-47949035c95a@arm.com> (raw)
In-Reply-To: <20240108134843.429769-3-vincent.guittot@linaro.org>
On 08/01/2024 14:48, Vincent Guittot wrote:
> Aggregate the different pressures applied on the capacity of CPUs and
> create a new function that returns the actual capacity of the CPU:
> get_actual_cpu_capacity()
function name scaling
(1) arch_scale_cpu_capacity() - uarch
(2) get_actual_cpu_capacity() - hw + cpufreq/thermal of (1)
(3) capacity_of() - rt (rt/dl/irq) of (2) (used by fair)
Although (1) - (3) are very close to each other from the functional
standpoint, their names are not very coherent.
I assume this makes it hard to understand all of this when reading the
code w/o knowing these patches before.
Why is (2) tagged with 'actual'?
This is especially visible in feec() where local variable cpu_cap
relates to (3) whereas cpu_actual_cap related to (2).
[...]
next prev parent reply other threads:[~2024-01-09 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 13:48 [PATCH v3 0/5] Rework system pressure interface to the scheduler Vincent Guittot
2024-01-08 13:48 ` [PATCH v3 1/5] cpufreq: Add a cpufreq pressure feedback for " Vincent Guittot
2024-01-08 16:35 ` Dietmar Eggemann
2024-01-08 16:46 ` Vincent Guittot
2024-01-09 11:24 ` Vincent Guittot
2024-01-08 13:48 ` [PATCH v3 2/5] sched: Take cpufreq feedback into account Vincent Guittot
2024-01-09 11:22 ` Dietmar Eggemann [this message]
2024-01-09 14:30 ` Vincent Guittot
2024-01-10 13:51 ` Dietmar Eggemann
2024-01-10 17:25 ` Vincent Guittot
2024-01-08 13:48 ` [PATCH v3 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Vincent Guittot
2024-01-08 13:48 ` [PATCH v3 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Vincent Guittot
2024-01-09 11:56 ` Dietmar Eggemann
2024-01-09 13:33 ` Vincent Guittot
2024-01-08 13:48 ` [PATCH v3 5/5] sched/pelt: Remove shift of thermal clock Vincent Guittot
2024-01-09 11:33 ` [PATCH v3 0/5] Rework system pressure interface to the scheduler Dietmar Eggemann
2024-01-09 13:29 ` Vincent Guittot
2024-01-10 18:10 ` Dietmar Eggemann
2024-01-19 17:57 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb25afab-9586-455a-b8c1-47949035c95a@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=andersson@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=juri.lelli@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox