From: Georgi Djakov <georgi.djakov@linaro.org>
To: Quentin Perret <quentin.perret@arm.com>
Cc: gregkh@linuxfoundation.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net, robh+dt@kernel.org, mturquette@baylibre.com,
khilman@baylibre.com, vincent.guittot@linaro.org,
skannan@codeaurora.org, bjorn.andersson@linaro.org,
amit.kucheria@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, evgreen@chromium.org,
dianders@chromium.org, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, abailon@baylibre.com,
maxime.ripard@bootlin.com, arnd@arndb.de,
thierry.reding@gmail.com, ksitaraman@nvidia.com,
sanjayc@nvidia.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v11 8/8] interconnect: sdm845: Fix build failure after cmd_db API change
Date: Fri, 7 Dec 2018 18:47:22 +0200 [thread overview]
Message-ID: <fb5d11cd-6729-5521-c828-9bfeedba9ce0@linaro.org> (raw)
In-Reply-To: <20181207162733.pdd62qvqzd6xk4nr@queper01-lin>
Hi Quentin,
On 12/7/18 18:27, Quentin Perret wrote:
> Hi Georgi,
>
> On Friday 07 Dec 2018 at 17:29:17 (+0200), Georgi Djakov wrote:
>> Recently the cmd_db_read_aux_data() function was changed to avoid using
>> memcpy and return a pointer instead. Update the code to the new API and
>> fix the build failure.
>>
>> Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>> ---
>> drivers/interconnect/qcom/sdm845.c | 26 ++++++++++++++------------
>
> IIUC this file is introduced by patch 5. Should the fix be squashed
> into patch 5 directly ? Just to keep things bisectable.
The reason why i have split it as a separate change is because as a
separate change it would be easier to review & test for the people who
are already familiar with the rest of the series.
Another minor reason is that a separate patch will also make the life a
bit easier for some people who are back-porting this to kernels using
the older version of the cmd_db API.
The commit that changed the cmd_db API is not yet in mainline, but in
linux-next. I am not sure what is preferred in this case?
Thanks,
Georgi
next prev parent reply other threads:[~2018-12-07 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 15:29 [PATCH v11 0/8] Introduce on-chip interconnect API Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 1/8] interconnect: Add generic " Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 2/8] dt-bindings: Introduce interconnect binding Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 3/8] interconnect: Allow endpoints translation via DT Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 4/8] interconnect: Add debugfs support Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 5/8] interconnect: qcom: Add sdm845 interconnect provider driver Georgi Djakov
2018-12-07 23:30 ` Matthias Kaehlcke
2018-12-08 0:24 ` Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 6/8] arm64: dts: sdm845: Add interconnect provider DT nodes Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 7/8] MAINTAINERS: add a maintainer for the interconnect API Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 8/8] interconnect: sdm845: Fix build failure after cmd_db API change Georgi Djakov
2018-12-07 16:27 ` Quentin Perret
2018-12-07 16:47 ` Georgi Djakov [this message]
2018-12-07 17:14 ` Quentin Perret
2018-12-07 21:29 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5d11cd-6729-5521-c828-9bfeedba9ce0@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=abailon@baylibre.com \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=ksitaraman@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sanjayc@nvidia.com \
--cc=seansw@qti.qualcomm.com \
--cc=skannan@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox