From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66ADE13C900 for ; Tue, 28 May 2024 09:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716887287; cv=none; b=rvFBxgogy7QPxMyNUWbuQ03+cTav71jUkXbuQZnp5yMdPHU3EpYIy9w1nAR8Tt7QpO8xnnslkHzIbGmXfj9NlIEc8y0mPbcG1u34vH8Vj+MG5dN2WgLculs6FrJkWLRyzhnfRXPUbFH5NxcnX4zu6JOuP8klgaRK0zoPyR6xLuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716887287; c=relaxed/simple; bh=9+CGOjqCFI8cBZqMQUSyJVRaj598mOEhBKpeMA2uMMY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Wz29aSc85Q4kZXizOZo4mDZBKrpyLCkdrHZKlSj3bs853A5g/E/azQL18dW/bC77tLg6RJn3TamrZrABZRtyWkgrcSGcamhLMksueUsf8yU9qQGBoVqnsYCV4yiPwYRs4977BpAbhtOQKSs4vNLF9o3cWq7bEDH12zfaJV3QfoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IUcK+Hhs; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IUcK+Hhs" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4210aa012e5so4662565e9.0 for ; Tue, 28 May 2024 02:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716887284; x=1717492084; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=a3SQwXIIXHjRM5uNeBKtEGihfqD66qoKItzKJ4EdXAo=; b=IUcK+Hhs1shSX/so/CSGKdfwUlBwf+/zKWTFhP4T44UQK2MCURsKkU56ec+C86Uof1 QfvkBtKXm9MK3gc9vakfiSAqp7BesOtlhMKAL1tOwriQMQdCMfbNC7L2zeROeZXJCLgG v80QdUVfZhllyakBy2mgx2a7PBrEroKK3VZGgLmB1kFfnL83ax9cvQOSCtmbbzra/F/q imEVG7xIhKjA9kAY0UoRmCXZ+UhfkjkIWiexXcBRn9syGI8xQBiCXu+jTOWgIZeqD8TR NPgb5vh6gZa9HtnLwHlYGiKqtllc+aP2FKE66Y7x5ggzorKSAoIVrgGvbiK9qeC9CiRK N2YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716887284; x=1717492084; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=a3SQwXIIXHjRM5uNeBKtEGihfqD66qoKItzKJ4EdXAo=; b=SGue7UdK92WLZzVMUWvqrNzxZGbnmQK1cJVLjN/bOucXGs0DVzNpyLWpZrqYG9Tz57 q8T5uScIIIoSU8xLgeKJ0R2Hra8XKgvJwt0FBhjyC2zakkffuGFMqRRkquVc+gwH8nSX RjsP6ktoL+f0GFuPqILwtQ3gDVVlRv41/9Km4m91MjXaUryYcZOUoDUrndMgqThF+9QU sDHqpKyB+QVpD0Vt3EHzyaNft1sTQ2wfbBhCqEz0SCc5UrtQ5odI0ERHm55fO32ph39P uN8uLBj3unW/O6MeB93Vy537AB0KhzuDBi/k4hs8Zi7xriBzn9gDpaklkrLQCuY83Uu9 ujlQ== X-Forwarded-Encrypted: i=1; AJvYcCUGI7vkAXHkhfJx08A79SeTxYzskPmum6OBlEESgslR2N0Er/4bwUxom3hRba6+Ggi1pxXwm/3pSDnD2b3LYSOcnbQx+ZUHihQ= X-Gm-Message-State: AOJu0YzQ1IuygL/49+T0D1fWRjnEJjZr7EDgMatZJCkmWkNUzIQmjfm1 avdZaYcZHSy5dCd6e3JaxNX9pQVdQKlTkvql2PWcDMPAsoOrVPMPrNeMWJtgqE8= X-Google-Smtp-Source: AGHT+IEe5BlH9PQdZyM3Yr+PHsNxwDNOOPiWSviwZgKb7/NFJzJaatF7rZUzlXn8gDyUKiEed9NoCA== X-Received: by 2002:a05:600c:4f03:b0:41b:a8e8:3ff6 with SMTP id 5b1f17b1804b1-42108a59341mr95487685e9.11.1716887283658; Tue, 28 May 2024 02:08:03 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:8f19:f965:3f93:6385? ([2a01:e0a:982:cbb0:8f19:f965:3f93:6385]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421089ae96bsm135209155e9.35.2024.05.28.02.08.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 02:08:03 -0700 (PDT) Message-ID: Date: Tue, 28 May 2024 11:08:02 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 3/3] arm64: dts: amlogic: a4: add power domain controller node To: Xianwei Zhao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Ulf Hansson Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20240528-a4_secpowerdomain-v1-0-2a9d7df9b128@amlogic.com> <20240528-a4_secpowerdomain-v1-3-2a9d7df9b128@amlogic.com> <70083d10-483e-4daf-a408-020f0147c5cf@amlogic.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <70083d10-483e-4daf-a408-020f0147c5cf@amlogic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/05/2024 11:00, Xianwei Zhao wrote: > Hi Neil, >    Thanks for your quickly reply. > > On 2024/5/28 16:46, Neil Armstrong wrote: >> [ EXTERNAL EMAIL ] >> >> On 28/05/2024 10:39, Xianwei Zhao via B4 Relay wrote: >>> From: Xianwei Zhao >>> >>> Add power domain controller node for Amlogic A4 SoC >>> >>> Signed-off-by: Xianwei Zhao >>> --- >>>   arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi | 4 ++++ >>>   arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi        | 5 +++++ >>>   2 files changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi >>> index b6106ad4a072..eebde77ae5b4 100644 >>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi >>> @@ -27,6 +27,10 @@ xtal: xtal-clk { >>>               #clock-cells = <0>; >>>       }; >>> >>> +     sm: secure-monitor { >>> +             compatible = "amlogic,meson-gxbb-sm"; >>> +     }; >>> + >>>       soc { >>>               compatible = "simple-bus"; >>>               #address-cells = <2>; >>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi >>> index 73ca1d7eed81..917c05219b9c 100644 >>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi >>> @@ -37,4 +37,9 @@ cpu3: cpu@3 { >>>                       enable-method = "psci"; >>>               }; >>>       }; >>> + >>> +     pwrc: power-controller { >>> +             compatible = "amlogic,a4-pwrc"; >>> +             #power-domain-cells = <1>; >>> +     }; >> >> pwrc is supposed to be a child of secure-monitor. >> > Considered writing it like this when I wrote this. > > Here are two approaches: one is to include secure-monitor in the comm dtsi and fill power-controller by aliases in dtsi of each chip, while the other is to directly include secure-monitor in the dtsi of each chip. Which one do you suggest? The bindings mandates it to be a child of the secure monitor. Neil > >> Neil >> >>>   }; >>> >>