Re: [PATCH] thermal/drivers/rockchip: add missing rk3328 mapping entry

Dragan Simic
2025-02-07T17:15:24Z

Hello Trevor,

On 2025-02-07 17:47, Trevor Woerner wrote:
> The mapping table for the rk3328 is missing the entry for -25°C which
> is
> found in the TRM[1] §9.5.2 "Temperature-to-code mapping".
>
> NOTE: the kernel uses the tsadc_q_sel=1'b1 mode which is defined as:
> 4096-. Whereas the table in the TRM gives the code
> "3774" for -25°C, the kernel uses 4096-3774=322.
>
> Link:
> https://opensource.rock-chips.com/images/9/97/Rockchip_RK3328TRM_V1.1-Part1-20170321.pdf
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>

Thanks for the patch. I think this should also include a Fixes tag
and be submitted for inclusion into stable kernels.

> ---
> drivers/thermal/rockchip_thermal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/rockchip_thermal.c
> b/drivers/thermal/rockchip_thermal.c
> index f551df48eef9..a8ad85feb68f 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -386,6 +386,7 @@ static const struct tsadc_table rk3328_code_table[]
> = {
> {296, -40000},
> {304, -35000},
> {313, -30000},
> + {322, -25000},
> {331, -20000},
> {340, -15000},
> {349, -10000},