From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@sisk.pl, daniel.lezcano@linaro.org
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 09/16] cpuidle: reduce code duplication inside cpuidle_idle_call()
Date: Thu, 3 Oct 2013 21:26:48 +0530 [thread overview]
Message-ID: <fcc808789f01e07d7ce93c9959df50a667390c7c.1380815504.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1380815504.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1380815504.git.viresh.kumar@linaro.org>
We are doing this twice in cpuidle_idle_call() routine:
drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP
Would be better if we actually store this in a local variable and use that. That
would remove code duplication as well as make this piece of code run fast (in
case compiler wasn't able to optimize it earlier)
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpuidle/cpuidle.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 518b542..ffc637a 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -118,6 +118,7 @@ int cpuidle_idle_call(void)
struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);
struct cpuidle_driver *drv;
int next_state, entered_state;
+ bool broadcast;
if (off || !initialized)
return -ENODEV;
@@ -141,7 +142,9 @@ int cpuidle_idle_call(void)
trace_cpu_idle_rcuidle(next_state, dev->cpu);
- if (drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP)
+ broadcast = drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP;
+
+ if (broadcast)
clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER,
&dev->cpu);
@@ -151,7 +154,7 @@ int cpuidle_idle_call(void)
else
entered_state = cpuidle_enter_state(dev, drv, next_state);
- if (drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP)
+ if (broadcast)
clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT,
&dev->cpu);
--
1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2013-10-03 15:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 15:56 [PATCH V2 00/16] CPUIdle: Minor cleanups for 3.13 Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 01/16] cpuidle: fix indentation of cpumask Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 02/16] cpuidle: Fix comments in cpuidle core Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 03/16] cpuidle: make __cpuidle_get_cpu_driver() inline Viresh Kumar
2013-10-03 20:14 ` Paul Walmsley
2013-10-03 15:56 ` [PATCH V2 04/16] cpuidle: make __cpuidle_device_init() return void Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 05/16] cpuidle: make __cpuidle_driver_init() " Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 06/16] cpuidle: rearrange code in __cpuidle_driver_init() Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 07/16] cpuidle: rearrange __cpuidle_register_device() to keep minimal exit points Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 08/16] cpuidle: merge two if() statements for checking error cases Viresh Kumar
2013-10-03 15:56 ` Viresh Kumar [this message]
2013-10-03 15:56 ` [PATCH V2 10/16] cpuidle: replace multiline statements with single line in cpuidle_idle_call() Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 11/16] cpuidle: call cpuidle_get_driver() from after taking cpuidle_driver_lock Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 12/16] cpuidle: use drv instead of cpuidle_driver in show_current_driver() Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 13/16] cpuidle: free all state kobjects from cpuidle_free_state_kobj() Viresh Kumar
2013-11-20 8:03 ` Viresh Kumar
2013-11-20 8:03 ` Viresh Kumar
2013-11-21 1:05 ` Rafael J. Wysocki
2013-11-21 3:24 ` Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 14/16] cpuidle: don't calculate time-diff if entered_state < 0 Viresh Kumar
2013-11-20 8:04 ` Viresh Kumar
2013-11-21 1:06 ` Rafael J. Wysocki
2013-10-03 15:56 ` [PATCH V2 15/16] cpuidle: don't call poll_idle_init() for every cpu Viresh Kumar
2013-10-03 15:56 ` [PATCH V2 16/16] cpuidle: remove cpuidle_unregister_governor() Viresh Kumar
2013-10-03 21:07 ` [PATCH V2 00/16] CPUIdle: Minor cleanups for 3.13 Kevin Hilman
2013-10-04 5:23 ` Viresh Kumar
2013-10-23 5:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcc808789f01e07d7ce93c9959df50a667390c7c.1380815504.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).