From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3] PM / OPP: add missing of_node_put() for of_get_cpu_node() Date: Thu, 12 Oct 2017 13:58:51 -0700 Message-ID: References: <1507632519-19648-1-git-send-email-sudeep.holla@arm.com> <1507804343-2472-1-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:34246 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbdJLU6x (ORCPT ); Thu, 12 Oct 2017 16:58:53 -0400 In-Reply-To: <1507804343-2472-1-git-send-email-sudeep.holla@arm.com> Content-Language: en-US Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sudeep Holla , Viresh Kumar , linux-pm@vger.kernel.org Cc: Nishanth Menon , "Rafael J. Wysocki" On 10/12/2017 03:32 AM, Sudeep Holla wrote: > Commit 762792913f8c ("PM / OPP: Fix get sharing CPUs when hotplug is used") > moved away from using cpu_dev->of_node because of some limitations. > However commit 7467c9d95989 ("of: return of_get_cpu_node from > of_cpu_device_node_get if CPUs are not registered") added support to > falls back to of_get_cpu_node if called if CPUs are not registered yet. > > It adds the missing of_node_put for the CPU device nodes. This patch also > moves back to use of_cpu_device_node_get in dev_pm_opp_of_get_sharing_cpus > to avoid scanning the device tree again. > > Cc: Nishanth Menon > Cc: Stephen Boyd > Cc: "Rafael J. Wysocki" > Acked-by: Viresh Kumar > Fixes: 762792913f8c ("PM / OPP: Fix get sharing CPUs when hotplug is used") > Signed-off-by: Sudeep Holla > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project