From: Andi Kleen <andi@firstfloor.org>
To: Len Brown <lenb@kernel.org>
Cc: Len Brown <len.brown@intel.com>,
linux-pm@lists.linux-foundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] x86 idle floppy: delete disable_hlt()/enable_hlt()
Date: Thu, 24 Mar 2011 08:58:25 -0700 [thread overview]
Message-ID: <m239mcv7by.fsf@firstfloor.org> (raw)
In-Reply-To: <fb07f62522099f5d3f2b7aa6014329d716081b62.1300950095.git.len.brown@intel.com> (Len Brown's message of "Thu, 24 Mar 2011 03:08:27 -0400")
Len Brown <lenb@kernel.org> writes:
>
> floppy.c said:
>
> "disable hlt during certain critical i/o operations"
>
> x86/kernel/process.c said:
>
> "This halt magic was a workaround for ancient floppy DMA
> wreckage. It should be safe to remove."
AFAIK it was used on some 386/486s. I suspect it's safe to remove now.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-03-24 15:58 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1300950508-22746-1-git-send-email-lenb@kernel.org>
2011-03-24 7:08 ` [PATCH 1/5] x86 idle: remove "no-hlt" cmdline param Len Brown
[not found] ` <67e90d97e0a77df4acd0c75e1bacc7714e011f3e.1300950095.git.len.brown@intel.com>
2011-03-24 7:08 ` [PATCH 2/5] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag Len Brown
2011-03-24 7:08 ` [PATCH 3/5] x86 idle: remove NOP halt_works() Len Brown
2011-03-24 7:08 ` [PATCH 4/5] x86 idle floppy: delete disable_hlt()/enable_hlt() Len Brown
2011-03-24 7:08 ` [PATCH 5/5] x86 idle: remove NOP hlt_use_halt() Len Brown
[not found] ` <6bdee95bc92adfbe9de20c415e936bf1bb94993d.1300950095.git.len.brown@intel.com>
2011-03-25 19:02 ` Vaidyanathan Srinivasan
[not found] ` <fb07f62522099f5d3f2b7aa6014329d716081b62.1300950095.git.len.brown@intel.com>
2011-03-24 15:58 ` Andi Kleen [this message]
2011-03-31 6:03 ` [PATCH 0/9] x86 idle cruft removal - v2 Len Brown
[not found] ` <1301551404-8263-1-git-send-email-lenb@kernel.org>
2011-03-31 6:03 ` [PATCH 1/9] x86 idle: remove "no-hlt" cmdline param Len Brown
[not found] ` <67e90d97e0a77df4acd0c75e1bacc7714e011f3e.1301550524.git.len.brown@intel.com>
2011-03-31 6:03 ` [PATCH 2/9] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag Len Brown
2011-03-31 6:03 ` [PATCH 3/9] x86 idle: remove NOP halt_works() Len Brown
2011-03-31 6:03 ` [PATCH 4/9] x86 idle floppy: delete disable_hlt()/enable_hlt() Len Brown
2011-03-31 6:03 ` [PATCH 5/9] x86 idle: remove NOP hlt_use_halt() Len Brown
2011-03-31 6:03 ` [PATCH 6/9] x86 idle APM: delete apm_cpu_idle(), and its use of (pm_idle)() Len Brown
2011-03-31 6:03 ` [PATCH 7/9] x86 idle: do not EXPORT_SYMBOL pm_idle and default_idle Len Brown
2011-03-31 6:03 ` [PATCH 8/9] x86 idle: move mwait_idle_with_hints() to where it is used Len Brown
2011-03-31 6:03 ` [PATCH 9/9] x86 idle: delete mwait_idle() Len Brown
[not found] ` <b048802b0285a5ff28e74a4309d833116174904a.1301550524.git.len.brown@intel.com>
2011-03-31 6:12 ` [PATCH 2/9] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag Ingo Molnar
[not found] ` <20110331061247.GA24786@elte.hu>
2011-03-31 7:02 ` Len Brown
[not found] ` <alpine.LFD.2.02.1103310252160.8569@x980>
2011-03-31 8:18 ` Ingo Molnar
[not found] ` <20110331081800.GH5938@elte.hu>
2011-03-31 9:23 ` Alan Cox
[not found] ` <20110331102355.17d30a38@lxorguk.ukuu.org.uk>
2011-03-31 9:27 ` Ingo Molnar
[not found] ` <20110331092721.GA16570@elte.hu>
2011-03-31 9:33 ` Alan Cox
[not found] ` <20110331103320.5a72ff8c@lxorguk.ukuu.org.uk>
2011-03-31 9:35 ` Ingo Molnar
[not found] ` <20110331093528.GA19288@elte.hu>
2011-03-31 14:19 ` H. Peter Anvin
[not found] ` <4D948D86.2050607@zytor.com>
2011-03-31 14:41 ` Alan Cox
[not found] ` <20110331154103.70d88899@lxorguk.ukuu.org.uk>
2011-03-31 15:09 ` H. Peter Anvin
2011-03-31 18:07 ` Len Brown
[not found] ` <alpine.LFD.2.02.1103311336320.9662@x980>
2011-03-31 18:28 ` H. Peter Anvin
[not found] ` <9797d1edfe558e20297785ce5b4e26339b74ea2c.1301550524.git.len.brown@intel.com>
2011-04-01 11:02 ` [PATCH 9/9] x86 idle: delete mwait_idle() Andreas Herrmann
2011-03-31 6:39 ` [PATCH 0/9] x86 idle cruft removal - v2 Trinabh Gupta
[not found] ` <4D942191.2080408@linux.vnet.ibm.com>
2011-03-31 7:21 ` Len Brown
2011-03-31 9:45 ` Alan Cox
[not found] ` <20110331104549.3065ab29@lxorguk.ukuu.org.uk>
2011-03-31 10:28 ` Ingo Molnar
2011-04-01 4:24 ` Len Brown
[not found] ` <alpine.LFD.2.02.1104010020280.2797@x980>
2011-04-01 9:38 ` Trinabh Gupta
[not found] ` <4D959D25.5010805@linux.vnet.ibm.com>
2011-04-01 18:33 ` Len Brown
2011-04-02 6:22 ` idle cleanup - v3 Len Brown
[not found] ` <1301725380-10579-1-git-send-email-lenb@kernel.org>
2011-04-02 6:22 ` [PATCH 01/18] cpuidle: menu: fixed wrapping timers at 4.294 seconds Len Brown
[not found] ` <c82cf78992a66bfa7f0c82aeb20ba6922127463b.1301724243.git.len.brown@intel.com>
2011-04-02 6:22 ` [PATCH 02/18] x86 idle floppy: deprecate disable_hlt() Len Brown
2011-04-02 6:22 ` [PATCH 03/18] x86 idle APM: deprecate CONFIG_APM_CPU_IDLE Len Brown
2011-04-02 6:22 ` [PATCH 04/18] x86 idle: EXPORT_SYMBOL(default_idle, pm_idle) only when APM demands it Len Brown
2011-04-02 6:22 ` [PATCH 05/18] x86 idle: deprecate "no-hlt" cmdline param Len Brown
2011-04-02 6:22 ` [PATCH 06/18] x86 idle: deprecate mwait_idle() and "idle=mwait" " Len Brown
2011-04-02 6:22 ` [PATCH 07/18] x86 idle: clarify AMD erratum 400 workaround Len Brown
2011-04-02 6:22 ` [PATCH 08/18] cpuidle: create bootparam "cpuidle.off=1" Len Brown
2011-04-02 6:22 ` [PATCH 09/18] cpuidle: replace xen access to x86 pm_idle and default_idle Len Brown
2011-04-02 6:22 ` [PATCH 10/18] x86 idle: move mwait_idle_with_hints() to where it is used Len Brown
2011-04-02 6:22 ` [PATCH 11/18] cpuidle: stop using pm_idle Len Brown
2011-04-02 6:22 ` [PATCH 12/18] 2.6.40: x86 idle: remove deprecated "no-hlt" cmdline param Len Brown
2011-04-02 6:22 ` [PATCH 13/18] 2.6.40: x86 idle: remove deprecated "hlt_bug: no" in 32-bit /proc/cpuinfo Len Brown
2011-04-02 6:22 ` [PATCH 14/18] 2.6.40: x86 idle floppy: remove deprecated disable_hlt()/enable_hlt() Len Brown
2011-04-02 6:22 ` [PATCH 15/18] 2.6.40: x86 idle: remove deprecated hlt_use_halt() Len Brown
2011-04-02 6:22 ` [PATCH 16/18] 2.6.40: x86 idle APM: remove deprecated apm_cpu_idle() Len Brown
2011-04-02 6:22 ` [PATCH 17/18] 2.6.40: x86 idle: do not export default_idle() and (pm_idle)() Len Brown
2011-04-02 6:23 ` [PATCH 18/18] 2.6.40: x86 idle: remove deprecated mwait_idle() Len Brown
[not found] ` <68477f71a39cd0ba9acd40e94e49969cbe1bec79.1301724243.git.len.brown@intel.com>
2011-04-02 8:23 ` [PATCH 07/18] x86 idle: clarify AMD erratum 400 workaround Borislav Petkov
[not found] ` <20110402082316.GA21804@liondog.tnic>
2011-04-02 19:19 ` Len Brown
[not found] ` <alpine.LFD.2.02.1104021442460.18682@x980>
2011-04-02 19:22 ` [PATCH 07/18] x86 idle: clarify AMD erratum 400 workaround -v2 Len Brown
[not found] ` <alpine.LFD.2.02.1104021521330.18682@x980>
2011-04-03 9:00 ` Borislav Petkov
[not found] ` <e2f656a28f548ed19c829563e5168ce48026570b.1301724243.git.len.brown@intel.com>
2011-04-04 15:33 ` [Xen-devel] [PATCH 09/18] cpuidle: replace xen access to x86 pm_idle and default_idle Konrad Rzeszutek Wilk
[not found] ` <392e1ffeeaefd448f69d45041fe4406fbd197852.1301724243.git.len.brown@intel.com>
2011-04-02 11:28 ` [PATCH 03/18] x86 idle APM: deprecate CONFIG_APM_CPU_IDLE Alan Cox
[not found] ` <20110402122810.1371afa8@lxorguk.ukuu.org.uk>
2011-04-02 18:28 ` Len Brown
[not found] ` <alpine.LFD.2.02.1104021427040.18682@x980>
2011-04-02 19:44 ` Alan Cox
2011-04-08 6:22 ` Pavel Machek
[not found] ` <dba24a423948935d0a0c1eb32414a476f3f90e02.1301724243.git.len.brown@intel.com>
2011-04-02 11:28 ` [PATCH 04/18] x86 idle: EXPORT_SYMBOL(default_idle, pm_idle) only when APM demands it Alan Cox
[not found] ` <20110402122857.5fb7d2b7@lxorguk.ukuu.org.uk>
2011-04-02 12:21 ` Trinabh Gupta
[not found] ` <5d9716021b20302ece48fd486bbad9bcb2502353.1301724243.git.len.brown@intel.com>
2011-04-02 11:40 ` [PATCH 16/18] 2.6.40: x86 idle APM: remove deprecated apm_cpu_idle() Alan Cox
[not found] ` <20110402124054.49c3a3f4@lxorguk.ukuu.org.uk>
2011-04-02 19:44 ` Len Brown
[not found] ` <alpine.LFD.2.02.1104021529580.18682@x980>
2011-04-02 21:00 ` Alan Cox
[not found] ` <20110402220021.74ecdb5b@lxorguk.ukuu.org.uk>
2011-04-03 2:48 ` Trinabh Gupta
[not found] ` <4D97E018.1090504@linux.vnet.ibm.com>
2011-04-04 10:05 ` Alan Cox
[not found] ` <5f8cf82855ca448698efe66f48779972ad08ffc0.1301724243.git.len.brown@intel.com>
2011-04-25 10:41 ` [PATCH 11/18] cpuidle: stop using pm_idle Trinabh Gupta
[not found] ` <d0d4b0749cf60042ce56636fdb019ab496fb45ff.1301724243.git.len.brown@intel.com>
2011-07-15 11:27 ` [PATCH 08/18] cpuidle: create bootparam "cpuidle.off=1" Deepthi Dharwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m239mcv7by.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox