Re: [PATCH 2/4] PM / Runtime: Prevent re-resuming devices in pm_runtime_force_resume()

[Kevin Hilman <khilman@baylibre.com>]

Ulf Hansson <ulf.hansson@linaro.org> writes:

> If the device has already been resumed before pm_runtime_force_resume() is
> invoked, prevent calling the ->runtime_resume() callback for the device,
> as it's not the expected behaviour from the subsystem/driver.

I'm not following how this description matches the code.

Based on the code, it seems like it should say "If the device has not
been runtime suspended, don't runtime resume it."   IOW, "device has
already been resumed" is not what pm_runtime_status_suspended() is
checking for.

Kevin

> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/base/power/runtime.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index b746904..09e4eb1 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -1506,6 +1506,9 @@ int pm_runtime_force_resume(struct device *dev)
>  		goto out;
>  	}
>  
> +	if (!pm_runtime_status_suspended(dev))
> +		goto out;
> +
>  	ret = pm_runtime_set_active(dev);
>  	if (ret)
>  		goto out;