From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH] cpufreq: arm_big_little: fix module license spec Date: Thu, 07 Aug 2014 16:00:20 +0200 Message-ID: References: <1406792216-827-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:36396 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757335AbaHGOAW (ORCPT ); Thu, 7 Aug 2014 10:00:22 -0400 In-Reply-To: <1406792216-827-1-git-send-email-u.kleine-koenig@pengutronix.de> ("Uwe =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Thu, 31 Jul 2014 09:36:56 +0200") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Viresh Kumar , Sudeep Holla , kernel@pengutronix.de, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Uwe Kleine-K=C3=B6nig writes: > Having no license specification in a module taints the kernel during = load > with: > > arm_big_little: module license 'unspecified' taints kernel. > > and also the linker doesn't allow it to make use of GPL-exported symb= ols > which in this case also results in errors like: > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > . The header of the driver specifies a GPL v2 license, so note that > accordingly. While at it also add a description and an author and fix > the license in a companion file to explicit v2. > > Reported-by: Andreas Schwab > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/cpufreq/arm_big_little.c | 4 ++++ > drivers/cpufreq/arm_big_little_dt.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_b= ig_little.c > index 1f4d4e315057..b600f3107bef 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_= ops *ops) > arm_bL_ops =3D NULL; > } > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > + > +MODULE_AUTHOR("Viresh Kumar "); > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > +MODULE_LICENSE("GPL v2"); drivers/cpufreq/arm_big_little.c:613:15: error: expected declaration sp= ecifiers or =E2=80=98...=E2=80=99 before string constant MODULE_AUTHOR("Viresh Kumar "); ^ drivers/cpufreq/arm_big_little.c:614:20: error: expected declaration sp= ecifiers or =E2=80=98...=E2=80=99 before string constant MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); ^ drivers/cpufreq/arm_big_little.c:615:16: error: expected declaration sp= ecifiers or =E2=80=98...=E2=80=99 before string constant MODULE_LICENSE("GPL v2"); ^ Andreas. --=20 Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B= 9D7 "And now for something completely different."