From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Oliva Subject: Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static Date: Fri, 04 Apr 2014 11:34:51 -0300 Message-ID: References: <254471b8cee296f860d24368cc467c00b5a07336.1396413826.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Viresh Kumar's message of "Thu, 3 Apr 2014 20:14:24 +0530") Sender: cpufreq-owner@vger.kernel.org To: Viresh Kumar Cc: "Rafael J. Wysocki" , Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List List-Id: linux-pm@vger.kernel.org On Apr 3, 2014, Viresh Kumar wrote: > On 3 April 2014 18:10, Alexandre Oliva wrote: >> FWIW, the same mistake is present in at32. > I will check others as well now :) Thanks! >> Reverting all the changes to loongson2_cpufreq.c in 652ed95d5fa makes >> cpufreq work again, as opposed to printing nan% in all cpufreq stats in >> cpufreq-info's output, and freezing shortly thereafter. > You must have a look at this: > https://lkml.org/lkml/2014/4/2/426 : [PATCH] MIPS/loongson2_cpufreq: > fix CPU clock rate setting Thanks, I confirm that patch is enough to avoid the symptoms I'd described. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer