From: Waqar Hameed <waqar.hameed@axis.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: <kernel@axis.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] power: supply: wm97xx: Use devm_power_supply_register()
Date: Wed, 14 Jan 2026 11:51:20 +0100 [thread overview]
Message-ID: <pndikd4tql3.a.out@axis.com> (raw)
In-Reply-To: <aWRPvn_BtqTb768i@venus> (Sebastian Reichel's message of "Mon, 12 Jan 2026 02:36:46 +0100")
On Mon, Jan 12, 2026 at 02:36 +0100 Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
[...]
>> @@ -257,7 +254,6 @@ static void wm97xx_bat_remove(struct platform_device *dev)
>> if (charge_gpiod)
>> free_irq(gpiod_to_irq(charge_gpiod), dev);
>> cancel_work_sync(&bat_work);
>> - power_supply_unregister(bat_psy);
>> kfree(prop);
>> }
>
> This free's prop before bat_psy. You fix that in the next patch, but
> to be bisectable those two patches must be swapped.
Ah, of course! Let's swap the patches in v2.
next prev parent reply other threads:[~2026-01-14 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 22:46 [PATCH 0/3] power: supply: wm97xx: Fix NULL pointer dereference in power_supply_changed() Waqar Hameed
2025-12-20 22:46 ` [PATCH 1/3] " Waqar Hameed
2025-12-20 22:46 ` [PATCH 2/3] power: supply: wm97xx: Use devm_power_supply_register() Waqar Hameed
2026-01-12 1:36 ` Sebastian Reichel
2026-01-14 10:51 ` Waqar Hameed [this message]
2025-12-20 22:46 ` [PATCH 3/3] power: supply: wm97xx: Use devm_kcalloc() Waqar Hameed
2026-01-12 1:56 ` (subset) [PATCH 0/3] power: supply: wm97xx: Fix NULL pointer dereference in power_supply_changed() Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pndikd4tql3.a.out@axis.com \
--to=waqar.hameed@axis.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox