From: Waqar Hameed <waqar.hameed@axis.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: <kernel@axis.com>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] power: supply: Add driver for TI BQ25630 charger
Date: Mon, 27 Jul 2026 14:29:11 +0200 [thread overview]
Message-ID: <pndpl08obu0.a.out@axis.com> (raw)
In-Reply-To: <amQD4oydNkzlOIeC@venus> (Sebastian Reichel's message of "Sat, 25 Jul 2026 02:57:51 +0200")
On Sat, Jul 25, 2026 at 02:57 +0200 Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
[...]
>> +static const struct power_supply_desc bq25630_charger_psy_desc = {
>> + .name = BQ25630_DRV_NAME,
>> + .type = POWER_SUPPLY_TYPE_USB_TYPE_C,
>
> Just POWER_SUPPLY_TYPE_USB, other USB details should be done via
> USB_TYPES (as you do already). I just cannot remove those types
> because they are used by some old drivers and exposed to userspace
> and thus ABI. I guesss I should add a _DEPRECATED to the in-kernel
> name.
Yeah, maybe we should do that. It would surely help the next person :)
>
> I will fix that up while applying.
Thanks!
next prev parent reply other threads:[~2026-07-27 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 22:01 [PATCH v3 0/2] Add driver for TI BQ25630 charger Waqar Hameed
2026-06-28 22:01 ` [PATCH v3 2/2] power: supply: " Waqar Hameed
2026-07-25 0:57 ` Sebastian Reichel
2026-07-27 12:29 ` Waqar Hameed [this message]
2026-06-28 22:01 ` [PATCH v3 1/2] dt-bindings: power: supply: Add " Waqar Hameed
2026-07-25 1:01 ` [PATCH v3 0/2] Add driver for " Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pndpl08obu0.a.out@axis.com \
--to=waqar.hameed@axis.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox