From: "Wentao Guan" <guanwentao@uniontech.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, 王昱力 <wangyuli@uniontech.com>
Cc: rafael <rafael@kernel.org>, pavel <pavel@kernel.org>,
tglx <tglx@linutronix.de>, mingo <mingo@redhat.com>,
bp <bp@alien8.de>, "dave.hansen" <dave.hansen@linux.intel.com>,
x86 <x86@kernel.org>, hpa <hpa@zytor.com>,
linux-pm <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
占俊 <zhanjun@uniontech.com>, 聂诚 <niecheng1@uniontech.com>,
陈麟轩 <chenlinxuan@uniontech.com>,
"Huacai Chen" <chenhuacai@loongson.cn>
Subject: Re: [RFC PATCH] x86 / hibernate: Eliminate the redundant smp_ops.play_dead assignment
Date: Thu, 27 Feb 2025 02:07:57 +0800 [thread overview]
Message-ID: <tencent_18C611757FED8D54331785FA@qq.com> (raw)
In-Reply-To: <CAJZ5v0iigAB97mGBe6Uvr0v0spjqDKan-0O9XGObt5b4ZBvM7A@mail.gmail.com>
Hello,
Thanks for your reply.
In my opinion, the only logic different before the patch is delete smp_ops.play_dead
save and restore, as the comment "the resumed kernel will decide itself" and same
logic as which in arch/arm64/kernel/hibernate.c, the ok path will work as expect.
When discussing the error path and ret value that we not restore play_dead,
I will try to analyze the difference between native_play_dead and resume_play_dead,
and sev_es_play_dead [the all possiable three value], and I see some mwait and hlt
way difference.[maybe it happens as disable the cpu failed and goes to Enable_cpus
path in func:resume_target_kernel in hibernate.c? ] Is that it desgin to do and we can
move it to a common place in hibernate.c and left some comments ?
BRs
Wentao Guan
next prev parent reply other threads:[~2025-02-26 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 7:43 [RFC PATCH] x86 / hibernate: Eliminate the redundant smp_ops.play_dead assignment WangYuli
2025-02-26 17:11 ` Rafael J. Wysocki
2025-02-26 18:07 ` Wentao Guan [this message]
2025-02-26 18:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_18C611757FED8D54331785FA@qq.com \
--to=guanwentao@uniontech.com \
--cc=bp@alien8.de \
--cc=chenhuacai@loongson.cn \
--cc=chenlinxuan@uniontech.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=niecheng1@uniontech.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangyuli@uniontech.com \
--cc=x86@kernel.org \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox