From: "tip-bot for Rafael J. Wysocki" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: rafael.j.wysocki@intel.com, tj@kernel.org,
linux-pm@vger.kernel.org, torvalds@linux-foundation.org,
hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
peterz@infradead.org, mingo@kernel.org
Subject: [tip:sched/core] sched/core: Fix comment regarding nr_iowait_cpu() and get_iowait_load()
Date: Thu, 4 Oct 2018 03:04:45 -0700 [thread overview]
Message-ID: <tip-9c2298aad355d8c1957df3015448fef333526934@git.kernel.org> (raw)
In-Reply-To: <3803514.xkx7zY50tF@aspire.rjw.lan>
Commit-ID: 9c2298aad355d8c1957df3015448fef333526934
Gitweb: https://git.kernel.org/tip/9c2298aad355d8c1957df3015448fef333526934
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
AuthorDate: Thu, 4 Oct 2018 11:05:14 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 4 Oct 2018 11:25:56 +0200
sched/core: Fix comment regarding nr_iowait_cpu() and get_iowait_load()
The comment related to nr_iowait_cpu() and get_iowait_load() confuses
cpufreq with cpuidle and is not very useful for this reason, so fix it.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux PM <linux-pm@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: e33a9bba85a8 "sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler"
Link: http://lkml.kernel.org/r/3803514.xkx7zY50tF@aspire.rjw.lan
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 56b3c1781276..fe0223121883 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2916,10 +2916,10 @@ unsigned long nr_iowait(void)
}
/*
- * Consumers of these two interfaces, like for example the cpufreq menu
- * governor are using nonsensical data. Boosting frequency for a CPU that has
- * IO-wait which might not even end up running the task when it does become
- * runnable.
+ * Consumers of these two interfaces, like for example the cpuidle menu
+ * governor, are using nonsensical data. Preferring shallow idle state selection
+ * for a CPU that has IO-wait which might not even end up running the task when
+ * it does become runnable.
*/
unsigned long nr_iowait_cpu(int cpu)
prev parent reply other threads:[~2018-10-04 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 9:05 [PATCH] sched: core: Fix comment regarding nr_iowait_cpu() and get_iowait_load() Rafael J. Wysocki
2018-10-04 10:04 ` tip-bot for Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9c2298aad355d8c1957df3015448fef333526934@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).