* [PATCH] msm: arm: qcom battery manager add OOI chemistry
@ 2025-08-11 11:10 chris.ruehl
2025-08-11 12:45 ` Dmitry Baryshkov
2025-08-11 14:41 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: chris.ruehl @ 2025-08-11 11:10 UTC (permalink / raw)
To: sre; +Cc: linux-arm-msm, linux-pm, linux-kernel, ruehlchr,
Christopher Ruehl
From: Christopher Ruehl <chris.ruehl@gtsys.com.hk>
The ASUS S15 xElite model report the Li-ion battery with an OOI, hence this
update the detection and return the appropriate type.
Signed-off-by: Christopher Ruehl <chris.ruehl@gtsys.com.hk>
---
drivers/power/supply/qcom_battmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
index 99808ea9851f..fdb2d1b883fc 100644
--- a/drivers/power/supply/qcom_battmgr.c
+++ b/drivers/power/supply/qcom_battmgr.c
@@ -982,7 +982,8 @@ static void qcom_battmgr_sc8280xp_strcpy(char *dest, const char *src)
static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry)
{
- if (!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN))
+ if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
+ (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
return POWER_SUPPLY_TECHNOLOGY_LION;
if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
return POWER_SUPPLY_TECHNOLOGY_LIPO;
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] msm: arm: qcom battery manager add OOI chemistry
2025-08-11 11:10 [PATCH] msm: arm: qcom battery manager add OOI chemistry chris.ruehl
@ 2025-08-11 12:45 ` Dmitry Baryshkov
2025-08-11 14:41 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-08-11 12:45 UTC (permalink / raw)
To: chris.ruehl; +Cc: sre, linux-arm-msm, linux-pm, linux-kernel, ruehlchr
On Mon, Aug 11, 2025 at 01:10:26PM +0200, chris.ruehl@gtsys.com.hk wrote:
> From: Christopher Ruehl <chris.ruehl@gtsys.com.hk>
>
> The ASUS S15 xElite model report the Li-ion battery with an OOI, hence this
> update the detection and return the appropriate type.
>
> Signed-off-by: Christopher Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> drivers/power/supply/qcom_battmgr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] msm: arm: qcom battery manager add OOI chemistry
2025-08-11 11:10 [PATCH] msm: arm: qcom battery manager add OOI chemistry chris.ruehl
2025-08-11 12:45 ` Dmitry Baryshkov
@ 2025-08-11 14:41 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2025-08-11 14:41 UTC (permalink / raw)
To: chris.ruehl; +Cc: sre, linux-arm-msm, linux-pm, linux-kernel, ruehlchr
On Mon, Aug 11, 2025 at 01:10:26PM +0200, chris.ruehl@gtsys.com.hk wrote:
> From: Christopher Ruehl <chris.ruehl@gtsys.com.hk>
>
The subject prefix should be "power: supply: qcom_battmgr: " to match
other changes in this driver. (see git log --oneline)
Regards,
Bjorn
> The ASUS S15 xElite model report the Li-ion battery with an OOI, hence this
> update the detection and return the appropriate type.
>
> Signed-off-by: Christopher Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> drivers/power/supply/qcom_battmgr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
> index 99808ea9851f..fdb2d1b883fc 100644
> --- a/drivers/power/supply/qcom_battmgr.c
> +++ b/drivers/power/supply/qcom_battmgr.c
> @@ -982,7 +982,8 @@ static void qcom_battmgr_sc8280xp_strcpy(char *dest, const char *src)
>
> static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry)
> {
> - if (!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN))
> + if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
> + (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
> return POWER_SUPPLY_TECHNOLOGY_LION;
> if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
> return POWER_SUPPLY_TECHNOLOGY_LIPO;
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-11 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 11:10 [PATCH] msm: arm: qcom battery manager add OOI chemistry chris.ruehl
2025-08-11 12:45 ` Dmitry Baryshkov
2025-08-11 14:41 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).