Linux PPP protocol development
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>
Cc: isdn@linux-pingi.de, linux-ppp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] isdn_ppp: Add checks for allocation failure in isdn_ppp_open()
Date: Sun, 01 Nov 2015 16:23:28 +0000	[thread overview]
Message-ID: <1446395008.25466.0.camel@decadent.org.uk> (raw)
In-Reply-To: <20151016.004606.1112196816016985692.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

On Fri, 2015-10-16 at 00:46 -0700, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Wed, 14 Oct 2015 18:51:14 +0100
> 
> > Compile-tested only.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> >  drivers/isdn/i4l/isdn_ppp.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/isdn/i4l/isdn_ppp.c
> b/drivers/isdn/i4l/isdn_ppp.c
> > index c4198fa..86f9abe 100644
> > --- a/drivers/isdn/i4l/isdn_ppp.c
> > +++ b/drivers/isdn/i4l/isdn_ppp.c
> > @@ -301,6 +301,8 @@ isdn_ppp_open(int min, struct file *file)
> >       is->compflags = 0;
> >  
> >       is->reset = isdn_ppp_ccp_reset_alloc(is);
> > +     if (!is->reset)
> > +             return -ENOMEM;
> 
> Ben, your email client has corrupted both of these patches.
> 
> Please fix this up and resubmit, thanks.

Sorry about that; it is a regression in Evolution 3.18.

Ben.

-- 
Ben Hutchings
Nothing is ever a complete failure; it can always serve as a bad example.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

      parent reply	other threads:[~2015-11-01 16:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 17:51 [PATCH net 1/2] isdn_ppp: Add checks for allocation failure in isdn_ppp_open() Ben Hutchings
2015-10-14 17:53 ` [PATCH 2/2] ppp, slip: Validate VJ compression slot parameters completely Ben Hutchings
2015-10-16  7:46 ` [PATCH net 1/2] isdn_ppp: Add checks for allocation failure in isdn_ppp_open() David Miller
2015-10-30 13:03   ` Josh Boyer
2015-11-01 16:23     ` Ben Hutchings
2015-11-01 16:23   ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446395008.25466.0.camel@decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=davem@davemloft.net \
    --cc=isdn@linux-pingi.de \
    --cc=linux-ppp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox