Linux PPP protocol development
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: linux-ppp@vger.kernel.org
Subject: Re: pppd 2.4.2b3 IPCP converge failure
Date: Mon, 22 Mar 2004 05:34:08 +0000	[thread overview]
Message-ID: <16478.31440.968776.931681@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1079855955.1133.48.camel@dell.tranquilitynj.net>

Andy writes:

> I'm wondering about the ConfReq packets, what is the second address
> field doing there (as in addrs 68.244.143.67 0.0.0.0) - that looks wrong
> to me. And there certainly seems to be a protocol error here in pppd
> handling the ConfRej's - this is from rfc1661, section 5.4:
> 
>       Reception of a valid Configure-Reject indicates that when a new
>       Configure-Request is sent, it MUST NOT include any of the
>       Configuration Options listed in the Configure-Reject.

It looks like the bug is here (line 723 of ipcp.c, in ipcp_cilen):

    if ((wo->neg_addr || wo->old_addrs) && !go->neg_addr && !go->old_addrs) {
        /* use the old style of address negotiation */
        go->old_addrs = 1;
    }

Receiving the conf-reject for the old CI_ADDRS option sets
go->old_addrs to 0.  Then when we send the next conf-request, this
code sets it to 1 again.

I'll have to think about the proper fix here.

Paul.

      parent reply	other threads:[~2004-03-22  5:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-21  7:59 pppd 2.4.2b3 IPCP converge failure Andy
2004-03-21 18:44 ` James Carlson
2004-03-21 19:21 ` Andy
2004-03-22  5:34 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16478.31440.968776.931681@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=linux-ppp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox