From: Paul Mackerras <paulus@samba.org>
To: Panagiotis Issaris <takis@lumumba.uhasselt.be>
Cc: linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org
Subject: Re: [PATCH] Missing failure handling
Date: Tue, 01 Aug 2006 04:29:43 +0000 [thread overview]
Message-ID: <17614.55479.693532.236235@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060720191629.GD7643@lumumba.uhasselt.be>
Panagiotis Issaris writes:
> - cardmap_set(&all_ppp_units, unit, ppp);
> + ret = cardmap_set(&all_ppp_units, unit, ppp);
> + if (ret != 0) {
> + printk(KERN_ERR "PPP: couldn't set cardmap\n");
This is a pretty useless message, in that it will mean nothing to a
user who sees it. It would be better to set ret = -ENOMEM and not
print the message, I think.
Paul.
prev parent reply other threads:[~2006-08-01 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 19:16 [PATCH] Missing failure handling Panagiotis Issaris
2006-07-25 8:24 ` Andrew Morton
2006-08-01 4:29 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17614.55479.693532.236235@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=takis@lumumba.uhasselt.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).