From: Guy Rouillier <guy-rouillier@speakeasy.net>
To: linux-ppp@vger.kernel.org
Subject: Re: pppd segfaults on AMD64 with ms-chap
Date: Wed, 09 Jun 2004 05:38:26 +0000 [thread overview]
Message-ID: <20040609013826.6d567100@localhost> (raw)
In-Reply-To: <40C59FC1.6070007@quadra.ru>
On Tue, 08 Jun 2004 15:15:13 +0400
mole <mole@quadra.ru> wrote:
> I am new to this list, sorry if this problem is already solved.
>
> I have tried to use pptp on fedora Core 2 for AMD64 and found that
> pppd segfaults on my machine when ms-chap is in use.
I just reported this same bug to the list two days ago. See "2.4.2 on
AMD64 Linux: assumes 4-byte long". I haven't gotten any replies yet, so
I'm going to try making the changes I found at the link I provided.
Unfortunately, the version of sha1.c in the kernel has the same bug in
it, so I'm going to have to rebuild the kernel. I tried just rebuilding
pppd, and that resulted in a kernel panic. More changes are required
than your patch includes; for example, the SHA1_CTX structure itself
must be modified.
>
> If pppd is compiled with openssl's sha then pppd doesn't segfault on
> authentication but mppe-enabled kernel then gives me oops in mppe sha
> code.
>
> The same kernel/pppd work fine in 32 bit mode.
>
> The problem proved to be in the broken sha1 implementation that
> assumes that unsigned long is 32-bit wide.
>
> The quick/minimal change to make it all work in 64-bit mode is in the
> attached patch. But it looks like the code needs more cleanups to make
>
> it obviously 64-bit safe.
>
> Best,
> Oleg Makarenko
>
>
>
>
>
>
>
--
Guy Rouillier
--
Guy Rouillier
next prev parent reply other threads:[~2004-06-09 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 7:16 pppd segfaults on AMD64 with ms-chap mole
2004-06-08 7:20 ` James Cameron
2004-06-09 5:38 ` Guy Rouillier [this message]
2004-06-11 7:59 ` mole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040609013826.6d567100@localhost \
--to=guy-rouillier@speakeasy.net \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).