From: Guy Rouillier <guy-rouillier@speakeasy.net>
To: linux-ppp@vger.kernel.org
Subject: Re: 2.4.2 on AMD64 Linux: assumes 4-byte long - FIXED!
Date: Thu, 10 Jun 2004 04:13:25 +0000 [thread overview]
Message-ID: <20040610001325.338bbc8d@localhost> (raw)
In-Reply-To: <20040606021936.14c69b54@localhost>
On Wed, 9 Jun 2004 16:24:08 +1000
James Cameron <james.cameron@hp.com> wrote:
> You're right.
>
> The patches to the PPP maintainers, chuck 'em at the mailing list, and
> ask for a response. If that fails, and it has to do with MPPE, send
> it to Frank Cusack <fcusack@fcusack.com>.
>
> The kernel, if it has to do with the PPP modules, again, chuck 'em at
> the linux-ppp mailing list. Paul Mackerras is ultimately responsible
> to promote them to the kernel team. Or you could explain it very
> carefully and try the LKML (Linux Kernel Mailing List).
James, thank you for the detailed reply. I mentioned this is my first
fix to the kernel, right? So I won't be to embarrassed to admit that
I'm a little confused about the kernel part. The fix I made definitely
worked. But I took the time to download the stock kernel from
kernel.org, and none of the files I changed are in there! I looked at
both the 2.6.3 and 2.6.6 versions. The version I'm working with is
Mandrake 2.6.3-9. The files I changed are drivers/net/sha1.c and
/drivers/net/sha1.h. In the Mandrake kernel source, /drivers/net also
has some files related to mppe: ppp_mppe_compress.c and ppp_mppe.mod.c.
The stock kernels from kernel.org don't have any of these four files!
Does that mean these files were added by Mandrake, and I should file a
bug report with them instead of ppp-linux? I'm surprised to learn that
mppe is not supported by the stock kernel. Appreciate your guiding a
newbie through this process.
>
> http://www.tldp.org/HOWTO/Software-Release-Practice-HOWTO/patching.html
> has some good hints to help your patch be accepted.
>
> I'm just an interested bystander. ;-)
>
> --
> James Cameron http://quozl.netrek.org/
> HP Open Source, Volunteer http://opensource.hp.com/
> PPTP Client Project, Release Engineer
> http://pptpclient.sourceforge.net/
--
Guy Rouillier
next prev parent reply other threads:[~2004-06-10 4:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 6:19 2.4.2 on AMD64 Linux: assumes 4-byte long Guy Rouillier
2004-06-09 5:48 ` 2.4.2 on AMD64 Linux: assumes 4-byte long - FIXED! Guy Rouillier
2004-06-10 4:13 ` Guy Rouillier [this message]
2004-06-10 4:43 ` James Cameron
2004-06-10 5:52 ` Guy Rouillier
2004-06-11 8:12 ` mole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040610001325.338bbc8d@localhost \
--to=guy-rouillier@speakeasy.net \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).