From: Guy Rouillier <guy-rouillier@speakeasy.net>
To: linux-ppp@vger.kernel.org
Subject: Fw: sha1 linux/mppe fix for 64-bit Linux
Date: Tue, 15 Jun 2004 16:42:06 +0000 [thread overview]
Message-ID: <20040615124206.00006526@ma1033> (raw)
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
This is one of two messages addressing a fix to the sha1 code in PPP to
enable it to work on 64-bit systems. The fix addressed in the current
message is for the linux/mppe component; the corresponding fix in the
other message is for the pppd component. Both sets of changes are
required. Without either I was encountering a segfault. With only the
pppd changes, I got a kernel panic. With both sets of changes, I am
able to use pptp with ppp to connect with a Microsoft server.
The major set of changes was to convert long data types to data types
with explicit length. Basically, I changed longs to 32-bit data values
and unsigned chars to 8-bit values. I also included a wrapper sha1()
function that I found in later versions of the code by the author, Steve
Reid.
This is my first submittal, so I apologize if I am not submitting this
properly. I followed the advice I was given and read the submittal
guidelines at gnu.org. However, after running diff -u against the ppp
component I pulled out of cvs and against my updates, I wasn't able to
run patch successfully against the result. I asked on the
help.gnu.utils newsgroup but received no reply and I'm going out of town
for the rest of the week. Because of this, I'm including both the diff
and my modified sources in the attached file. I will gladly redo this
when I return if there is a better way to do it.
--
Guy Rouillier
[-- Attachment #2: linux.tar.gz --]
[-- Type: application/octet-stream, Size: 3370 bytes --]
next reply other threads:[~2004-06-15 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-15 16:42 Guy Rouillier [this message]
2004-06-15 20:00 ` Fw: sha1 linux/mppe fix for 64-bit Linux Oleg Makarenko
2004-06-20 3:29 ` Guy Rouillier
2004-06-20 18:37 ` Oleg Makarenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040615124206.00006526@ma1033 \
--to=guy-rouillier@speakeasy.net \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).